Bug 183589

Summary:	Assertion failure in BidiResolverBase<...>::createBidiRunsForLine
Product:	WebKit	Reporter:	Sihui Liu <sihui_liu>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED WORKSFORME
Severity:	Normal	CC:	bfulgham, koivisto, mmaxfield, rniwa, simon.fraser, zalan
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Sihui Liu

Reported 2018-03-12 20:27:51 PDT

Reproduction steps: 1. Open https://stackoverflow.com/questions/7755088/what-does-href-expression-a-href-javascript-a-do Result: Hit the assertion: SHOULD NEVER BE REACHED /Volumes/Data/ws1/OpenSource/Source/WebCore/platform/text/BidiResolver.h(899) : void WebCore::BidiResolverBase<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiResolverWithIsolate<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun> >::createBidiRunsForLine(const Iterator &, WebCore::VisualDirectionOverride, bool) [Iterator = WebCore::InlineIterator, Run = WebCore::BidiRun, DerivedClass = WebCore::BidiResolverWithIsolate<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun>] 1 0x570ca2b5d WTFCrash 2 0x562d956cf WebCore::BidiResolverBase<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiResolverWithIsolate<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun> >::createBidiRunsForLine(WebCore::InlineIterator const&, WebCore::VisualDirectionOverride, bool) 3 0x562d49103 WebCore::constructBidiRunsForSegment(WebCore::BidiResolverWithIsolate<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun>&, WebCore::BidiRunList<WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::VisualDirectionOverride, bool) 4 0x562d46a3a WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolverWithIsolate<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int) 5 0x562d45119 WebCore::RenderBlockFlow::layoutRunsAndFloats(WebCore::LineLayoutState&, bool) 6 0x562d4b2dd WebCore::RenderBlockFlow::layoutLineBoxes(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 7 0x562ceda51 WebCore::RenderBlockFlow::layoutInlineChildren(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 8 0x562cec932 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 9 0x562cd05f9 WebCore::RenderBlock::layout() 10 0x562cf0788 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 11 0x562cedcb9 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 12 0x562cec955 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 13 0x562cd05f9 WebCore::RenderBlock::layout() 14 0x562c687ec WebCore::RenderElement::layoutIfNeeded() 15 0x562df62d0 WebCore::RenderFlexibleBox::layoutAndPlaceChildren(WebCore::LayoutUnit&, WTF::Vector<WebCore::FlexItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::LayoutUnit, bool, WTF::Vector<WebCore::RenderFlexibleBox::LineContext, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&) 16 0x562df1731 WebCore::RenderFlexibleBox::layoutFlexItems(bool) 17 0x562df0e2a WebCore::RenderFlexibleBox::layoutBlock(bool, WebCore::LayoutUnit) 18 0x562cd05f9 WebCore::RenderBlock::layout() 19 0x562cf0788 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 20 0x562cedcb9 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 21 0x562cec955 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 22 0x562cd05f9 WebCore::RenderBlock::layout() 23 0x562cf0788 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 24 0x562cedcb9 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 25 0x562cec955 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 26 0x562cd05f9 WebCore::RenderBlock::layout() 27 0x562cf0788 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 28 0x562cedcb9 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 29 0x562cec955 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 30 0x562cd05f9 WebCore::RenderBlock::layout() 31 0x562c687ec WebCore::RenderElement::layoutIfNeeded()

Attachments
Add attachment proposed patch, testcase, etc.

Sihui Liu

Comment 1 2018-05-22 10:11:22 PDT

Cannot reproduce now.

Myles C. Maxfield

Comment 2 2018-05-22 12:08:56 PDT

Thanks for following up on this!!

Note You need to log in before you can comment on or make changes to this bug.