Bug 183575

Summary: Add label on github when exporting wpt tests to w3c/web-platform-test repo
Product: WebKit Reporter: Brendan McLoughlin <brendan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dean_johnson, ews-watchlist, glenn, jbedard, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brendan McLoughlin
Reported 2018-03-12 12:45:24 PDT
Add label on github when exporting wpt tests to w3c/web-platform-test repo
Attachments
Patch (4.55 KB, patch)
2018-03-12 12:54 PDT, Brendan McLoughlin 		no flags
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2018-03-13 11:56 PDT, Brendan McLoughlin 		no flags
DetailsFormatted DiffDiff
Patch (6.30 KB, patch)
2018-03-14 07:35 PDT, Brendan McLoughlin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brendan McLoughlin
Comment 1 2018-03-12 12:54:54 PDT
Created attachment 335627 [details] Patch
youenn fablet
Comment 2 2018-03-12 13:37:40 PDT
Comment on attachment 335627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335627&action=review > Tools/Scripts/webkitpy/w3c/common.py:42 > +WEBKIT_EXPORT_PR_LABEL = 'webkit-export' common.py is imported from Chromium. Ideally, we would not want to change this file so that we can easily reimport it from Chromium. We can probably move it to test_export.py. > Tools/Scripts/webkitpy/w3c/test_exporter.py:181 > pr_number = self._github.create_pr(self._wpt_fork_remote + ':' + self._branch_name, self._commit_message, self._commit_message + "\n" + description) Would create_pr always succeed, or are there some cases where it might not be successful, in which case we should add some error handling?
Brendan McLoughlin
Comment 3 2018-03-12 13:44:49 PDT
Comment on attachment 335627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335627&action=review >> Tools/Scripts/webkitpy/w3c/test_exporter.py:181 >> pr_number = self._github.create_pr(self._wpt_fork_remote + ':' + self._branch_name, self._commit_message, self._commit_message + "\n" + description) > > Would create_pr always succeed, or are there some cases where it might not be successful, in which case we should add some error handling? When testing this change locally I saw `create_pr` fail when my github token was missing the required permissions and when a pr had already been created for given bug_id. I will add some error handling for these cases.
Brendan McLoughlin
Comment 4 2018-03-13 11:56:17 PDT
Created attachment 335706 [details] Patch
youenn fablet
Comment 5 2018-03-13 21:14:29 PDT
Comment on attachment 335706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335706&action=review > Tools/Scripts/webkitpy/w3c/test_exporter.py:189 > + _log.info('Error creating a pull request on github. Please ensure that the provided github token has the "public_repo" scope.') Might be easier to read if we put this method as a utility routine.
Brendan McLoughlin
Comment 6 2018-03-14 07:35:35 PDT
Created attachment 335767 [details] Patch
WebKit Commit Bot
Comment 7 2018-03-14 09:11:07 PDT
Comment on attachment 335767 [details] Patch Clearing flags on attachment: 335767 Committed r229600: <https://trac.webkit.org/changeset/229600>
WebKit Commit Bot
Comment 8 2018-03-14 09:11:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-03-14 09:12:37 PDT
<rdar://problem/38460383>
Note You need to log in before you can comment on or make changes to this bug.