Bug 183538

Summary: offlineasm should reset the Assembler's working state before doing another pass for a new target.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
mark.lam: review-, mark.lam: commit-queue-
proposed patch. msaboff: review+

Mark Lam
Reported 2018-03-09 18:20:51 PST
Patch coming.
Attachments
proposed patch. (1.53 KB, patch)
2018-03-09 18:29 PST, Mark Lam 		mark.lam: review-
mark.lam: commit-queue-
DetailsFormatted DiffDiff
proposed patch. (3.09 KB, patch)
2018-03-09 23:58 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-09 18:21:26 PST
<rdar://problem/38325955>
Mark Lam
Comment 2 2018-03-09 18:29:42 PST
Created attachment 335493 [details] proposed patch.
Mark Lam
Comment 3 2018-03-09 22:54:15 PST
Comment on attachment 335493 [details] proposed patch. Taking off review for now. I found another bug in this same class of errors. Will fix that bug as well before reposting a patch.
Mark Lam
Comment 4 2018-03-09 22:54:48 PST
<rdar://problem/38316707>
Mark Lam
Comment 5 2018-03-09 23:58:49 PST
Created attachment 335503 [details] proposed patch.
Michael Saboff
Comment 6 2018-03-10 11:28:56 PST
Comment on attachment 335503 [details] proposed patch. r=me
Mark Lam
Comment 7 2018-03-10 12:13:57 PST
Thanks for the review. Landed in r229506: <http://trac.webkit.org/r229506>.
Note You need to log in before you can comment on or make changes to this bug.