Bug 183508

Summary: Use alignas instead of compiler-specific attributes
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2018-03-09 02:43:44 PST
Use alignas instead of compiler-specific attributes
Attachments
Patch (13.26 KB, patch)
2018-03-09 02:46 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (13.26 KB, patch)
2018-03-09 02:58 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.26 KB, patch)
2018-03-09 03:14 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.21 KB, patch)
2018-03-09 04:20 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2018-04-08 22:06 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (19.51 KB, patch)
2018-04-09 12:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-03-09 02:46:32 PST
Created attachment 335408 [details] Patch
Yusuke Suzuki
Comment 2 2018-03-09 02:58:01 PST
Created attachment 335411 [details] Patch
Yusuke Suzuki
Comment 3 2018-03-09 03:14:04 PST
Created attachment 335413 [details] Patch
Yusuke Suzuki
Comment 4 2018-03-09 04:20:24 PST
Created attachment 335419 [details] Patch
Mark Lam
Comment 5 2018-04-08 13:46:23 PDT
Comment on attachment 335419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335419&action=review r=me > Source/JavaScriptCore/jit/JIT.h:172 > + // performance fluctuations. Try forcing alignment in an attempt to stabalize this. nit: /stabalize/stabilize/. I know this came from an old comment, but might as well fix it. > Source/WTF/wtf/Gigacage.cpp:35 > +alignas(void*) char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; This disagrees with the bmalloc definition which has it as alignas(GIGACAGE_BASE_PTRS_SIZE). Unless you have a reason to not do so, let's make it consistent with the bmalloc one. > Source/WTF/wtf/Gigacage.h:37 > +alignas(void*) extern WTF_EXPORTDATA char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; Ditto.
Yusuke Suzuki
Comment 6 2018-04-08 14:18:43 PDT
Comment on attachment 335419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335419&action=review >> Source/JavaScriptCore/jit/JIT.h:172 >> + // performance fluctuations. Try forcing alignment in an attempt to stabalize this. > > nit: /stabalize/stabilize/. I know this came from an old comment, but might as well fix it. Nice, fixed. >> Source/WTF/wtf/Gigacage.cpp:35 >> +alignas(void*) char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; > > This disagrees with the bmalloc definition which has it as alignas(GIGACAGE_BASE_PTRS_SIZE). Unless you have a reason to not do so, let's make it consistent with the bmalloc one. OK, changed. >> Source/WTF/wtf/Gigacage.h:37 >> +alignas(void*) extern WTF_EXPORTDATA char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; > > Ditto. Fixed.
Yusuke Suzuki
Comment 7 2018-04-08 14:30:08 PDT
Committed r230380: <https://trac.webkit.org/changeset/230380>
Radar WebKit Bug Importer
Comment 8 2018-04-08 14:31:16 PDT
<rdar://problem/39267802>
Yusuke Suzuki
Comment 9 2018-04-08 14:36:54 PDT
Comment on attachment 335419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335419&action=review >>> Source/WTF/wtf/Gigacage.cpp:35 >>> +alignas(void*) char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; >> >> This disagrees with the bmalloc definition which has it as alignas(GIGACAGE_BASE_PTRS_SIZE). Unless you have a reason to not do so, let's make it consistent with the bmalloc one. > > OK, changed. I've reverted this part to void* since some of the compilers do not support such a large alignment. Here, what we want is pointer size alignment. >>> Source/WTF/wtf/Gigacage.h:37 >>> +alignas(void*) extern WTF_EXPORTDATA char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; >> >> Ditto. > > Fixed. Ditto.
Yusuke Suzuki
Comment 10 2018-04-08 14:38:29 PDT
Committed r230381: <https://trac.webkit.org/changeset/230381>
Yusuke Suzuki
Comment 11 2018-04-08 21:55:28 PDT
Committed r230388: <https://trac.webkit.org/changeset/230388>
Yusuke Suzuki
Comment 12 2018-04-08 22:02:33 PDT
Hmmm, we enabled warnings on MSVC, which easily leads to build failures. I'll just disable JIT alignas for MSVC.
Yusuke Suzuki
Comment 13 2018-04-08 22:06:19 PDT
Reopening to attach new patch.
Yusuke Suzuki
Comment 14 2018-04-08 22:06:21 PDT
Created attachment 337481 [details] Patch Attempt to fix
Yusuke Suzuki
Comment 15 2018-04-09 04:28:06 PDT
Committed r230403: <https://trac.webkit.org/changeset/230403>
youenn fablet
Comment 16 2018-04-09 12:03:28 PDT
Reopening to attach new patch.
youenn fablet
Comment 17 2018-04-09 12:03:29 PDT
Created attachment 337517 [details] Patch
youenn fablet
Comment 18 2018-04-09 12:04:18 PDT
Wrong bug id
Mark Lam
Comment 19 2018-04-10 20:26:44 PDT
*** Bug 183617 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.