Bug 183494 – [webkitpy] Remove openssl command dependency.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Basuke Suzuki]

To launch websocket server, current implementation uses openssl command. The command is not available by default in Windows. Also what the command actually does is to separate the pem file into two parts. The source PEM file was not changed since it initially imported to the repository. I don't see any reason we can switch to simple text manipulation for this task.

[Basuke Suzuki]

Created attachment 335454 [details]
PATCH

[EWS Watchlist]

Comment on attachment 335454 [details]
PATCH

Attachment 335454 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6881995

New failing tests:
http/tests/websocket/tests/hybi/simple-wss.html
http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

[EWS Watchlist]

Created attachment 335462 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335454 [details]
PATCH

Attachment 335454 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6882362

New failing tests:
http/tests/websocket/tests/hybi/simple-wss.html
http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

[EWS Watchlist]

Created attachment 335465 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335454 [details]
PATCH

Attachment 335454 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6882518

New failing tests:
http/tests/websocket/tests/hybi/simple-wss.html
http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

[EWS Watchlist]

Created attachment 335469 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335454 [details]
PATCH

Attachment 335454 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6882915

New failing tests:
http/tests/websocket/tests/hybi/simple-wss.html
http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

[EWS Watchlist]

Created attachment 335477 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Basuke Suzuki]

Created attachment 335482 [details]
PATCH

[Ryosuke Niwa]

Comment on attachment 335482 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=335482&action=review

> Tools/Scripts/webkitpy/port/base.py:1015
> +                            use_tls=True, port=websocket_server.PyWebSocket.DEFAULT_WSS_PORT, private_key=private_key_file, certificate=certificate_file)

Nit: Wrong indentation. Always use 4 spaces.

[Ryosuke Niwa]

Comment on attachment 335482 [details]
PATCH

I meant cq-.

[Basuke Suzuki]

Created attachment 335604 [details]
FIX STYLE

[Basuke Suzuki]

(In reply to Ryosuke Niwa from comment #11)
> Comment on attachment 335482 [details]
> PATCH
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335482&action=review
> 
> > Tools/Scripts/webkitpy/port/base.py:1015
> > +                            use_tls=True, port=websocket_server.PyWebSocket.DEFAULT_WSS_PORT, private_key=private_key_file, certificate=certificate_file)
> 
> Nit: Wrong indentation. Always use 4 spaces.

Thanks for review. I fixed it.

[WebKit Commit Bot]

Comment on attachment 335604 [details]
FIX STYLE

Clearing flags on attachment: 335604

Committed r229541: <https://trac.webkit.org/changeset/229541>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.