Bug 183481

Summary:

Update libwebrtc up to 36af4e9614f707f733eb2340fae66d6325aaac5b

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alex, commit-queue, eric.carlson, ews-watchlist, jbedard, jonlee, ryanhaddad, webkit-bug-importer, youennf

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch from SVN checkout	none
Make patch smaller by removing tools/utilities changes	none
Make patch smaller by removing tools/utilities changes	none
Make patch smaller by removing tools/utilities changes	none
Make patch smaller by removing tools/utilities changes	none
Make patch smaller	none
Make patch smaller	none
Patch	none
Make patch smaller	none
Make patch smaller	none
Patch	none
Patch	none
Patch	none
patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

youenn fablet

Reported 2018-03-08 14:23:39 PST

Update libwebrtc up to 36af4e9614f707f733eb2340fae66d6325aaac5b

Attachments
Patch (31.76 MB, patch) 2018-03-08 14:38 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (32.19 MB, patch) 2018-03-08 16:13 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (28.01 MB, patch) 2018-03-08 22:55 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch from SVN checkout (38.93 MB, patch) 2018-03-09 08:49 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Make patch smaller by removing tools/utilities changes (4.53 MB, patch) 2018-03-09 09:41 PST, youenn fablet	no flags	Details Formatted Diff Diff
Make patch smaller by removing tools/utilities changes (2.17 MB, patch) 2018-03-09 09:53 PST, youenn fablet	no flags	Details Formatted Diff Diff
Make patch smaller by removing tools/utilities changes (1.88 MB, patch) 2018-03-09 10:12 PST, youenn fablet	no flags	Details Formatted Diff Diff
Make patch smaller by removing tools/utilities changes (1.31 MB, patch) 2018-03-09 10:22 PST, youenn fablet	no flags	Details Formatted Diff Diff
Make patch smaller (1.29 MB, patch) 2018-03-09 10:29 PST, youenn fablet	no flags	Details Formatted Diff Diff
Make patch smaller (1.68 MB, patch) 2018-03-09 10:33 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (31.41 MB, patch) 2018-03-09 11:08 PST, youenn fablet	no flags	Details Formatted Diff Diff
Make patch smaller (1.21 MB, patch) 2018-03-09 13:09 PST, youenn fablet	no flags	Details Formatted Diff Diff
Make patch smaller (87.47 KB, patch) 2018-03-09 13:13 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (31.39 MB, patch) 2018-03-09 13:35 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.35 MB, patch) 2018-03-09 14:00 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.35 MB, patch) 2018-03-09 14:23 PST, youenn fablet	no flags	Details Formatted Diff Diff
patch (4.35 MB, patch) 2018-03-09 14:42 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.54 MB, patch) 2018-03-12 13:56 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.50 MB, patch) 2018-03-12 14:43 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.53 MB, patch) 2018-03-12 17:15 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.50 MB, patch) 2018-03-13 14:24 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.50 MB, patch) 2018-03-13 15:04 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (21) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-03-08 14:38:56 PST

Created attachment 335348 [details] Patch

youenn fablet

Comment 2 2018-03-08 16:13:17 PST

Created attachment 335363 [details] Patch

youenn fablet

Comment 3 2018-03-08 22:55:16 PST

Created attachment 335397 [details] Patch

Jonathan Bedard

Comment 4 2018-03-09 08:49:56 PST

Created attachment 335426 [details] Patch from SVN checkout

youenn fablet

Comment 5 2018-03-09 09:41:30 PST

Created attachment 335429 [details] Make patch smaller by removing tools/utilities changes

youenn fablet

Comment 6 2018-03-09 09:53:38 PST

Created attachment 335430 [details] Make patch smaller by removing tools/utilities changes

youenn fablet

Comment 7 2018-03-09 10:12:52 PST

Created attachment 335436 [details] Make patch smaller by removing tools/utilities changes

youenn fablet

Comment 8 2018-03-09 10:22:54 PST

Created attachment 335437 [details] Make patch smaller by removing tools/utilities changes

youenn fablet

Comment 9 2018-03-09 10:29:43 PST

Created attachment 335438 [details] Make patch smaller

youenn fablet

Comment 10 2018-03-09 10:33:23 PST

Created attachment 335439 [details] Make patch smaller

youenn fablet

Comment 11 2018-03-09 11:08:21 PST

Created attachment 335441 [details] Patch

youenn fablet

Comment 12 2018-03-09 13:09:43 PST

Created attachment 335452 [details] Make patch smaller

youenn fablet

Comment 13 2018-03-09 13:13:47 PST

Created attachment 335453 [details] Make patch smaller

EWS Watchlist

Comment 14 2018-03-09 13:16:46 PST

Attachment 335453 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:24: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:27: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:27: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:30: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:32: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:35: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:37: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:56: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/fft_buffer.h:58: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:23: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:26: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:31: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:55: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/vector_buffer.h:57: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:17: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:24: The parameter name "factory" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:27: The parameter name "format" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:27: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:29: The parameter name "format" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:37: The parameter name "factory" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:41: The parameter name "format" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:47: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/stereocodecfactory.h:49: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:55: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:57: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_types.h:104: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:21: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:21: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:23: The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:27: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:27: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:30: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosinkinterface.h:32: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:27: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:30: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:33: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:35: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:48: The parameter name "sink" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:49: The parameter name "wants" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:52: The parameter name "sink" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:55: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:58: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/videosourceinterface.h:59: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:21: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:21: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:27: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/delay_estimate.h:29: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:33: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:33: The parameter name "mixer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:34: The parameter name "audio_processing" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:35: The parameter name "audio_device_module" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:35: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:56: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:58: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:62: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:67: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:69: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:70: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:74: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:75: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:86: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:87: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:88: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:92: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:94: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:98: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/audio/audio_transport_impl.h:100: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:16: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:15: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:20: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:47: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:54: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:56: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:58: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:58: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:61: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:65: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:87: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:88: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:92: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:94: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:97: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:98: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:100: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:119: Weird number o f spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:150: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:155: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:157: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:159: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:162: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:164: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:164: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:165: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:176: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/rtp_headers.h:178: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:21: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:22: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:27: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:32: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/events/rtc_event_alr_state.h:33: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:27: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:30: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:33: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:35: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:37: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:42: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:43: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/call/test/mock_audio_send_stream.h:45: One space before end of line comments [whitespace/comments] [5] Total errors found: 342 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 15 2018-03-09 13:35:50 PST

Created attachment 335455 [details] Patch

youenn fablet

Comment 16 2018-03-09 14:00:17 PST

Created attachment 335459 [details] Patch

youenn fablet

Comment 17 2018-03-09 14:23:03 PST

Created attachment 335463 [details] Patch

youenn fablet

Comment 18 2018-03-09 14:42:47 PST

Created attachment 335467 [details] patch

youenn fablet

Comment 19 2018-03-12 13:56:12 PDT

Created attachment 335636 [details] Patch

youenn fablet

Comment 20 2018-03-12 14:02:04 PDT

*** Bug 176865 has been marked as a duplicate of this bug. ***

youenn fablet

Comment 21 2018-03-12 14:43:33 PDT

Created attachment 335643 [details] Patch

EWS Watchlist

Comment 22 2018-03-12 14:50:34 PDT

Attachment 335643 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_types.h:104: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:48: The parameter name "window" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/include/audio_processing_statistics.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:102: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:55: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:57: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:290: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:33: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 155, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 83, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 137, in process_file self._processor.process(lines, file_path, **kwargs) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 961, in process checker.check(lines) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 4024, in check self.handle_style_error, self.min_confidence) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3879, in _process_lines enum_state, asm_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3826, in process_line file_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3121, in check_language check_include_line(filename, file_extension, clean_lines, line_number, include_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3074, in check_include_line previous_header_type = include_state.header_types[previous_line_number] KeyError: 16 If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 23 2018-03-12 17:15:30 PDT

Created attachment 335665 [details] Patch

EWS Watchlist

Comment 24 2018-03-12 17:20:17 PDT

Attachment 335665 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_types.h:104: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:48: The parameter name "window" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/include/audio_processing_statistics.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:102: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:55: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:57: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:290: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:33: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 155, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 83, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 137, in process_file self._processor.process(lines, file_path, **kwargs) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 961, in process checker.check(lines) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 4024, in check self.handle_style_error, self.min_confidence) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3879, in _process_lines enum_state, asm_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3826, in process_line file_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3121, in check_language check_include_line(filename, file_extension, clean_lines, line_number, include_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3074, in check_include_line previous_header_type = include_state.header_types[previous_line_number] KeyError: 16 If any of these errors are false positives, please file a bug against check-webkit-style.

Alejandro G. Castro

Comment 25 2018-03-13 04:07:12 PDT

Consider adding this to remove the style checker to the libwebrtc repository: diff --git a/Tools/Scripts/webkitpy/style/checker.py b/Tools/Scripts/webkitpy/style/checker.py index 9b43879b841..0106ee301b9 100644 --- a/Tools/Scripts/webkitpy/style/checker.py +++ b/Tools/Scripts/webkitpy/style/checker.py @@ -219,6 +219,7 @@ _PATH_RULES_SPECIFIER = [ # ([os.path.join('webkitpy', 'thirdparty'), os.path.join('Source', 'ThirdParty', 'ANGLE'), + os.path.join('Source', 'ThirdParty', 'libwebrtc'), os.path.join('Source', 'ThirdParty', 'openvr'), os.path.join('Source', 'ThirdParty', 'xdgmime'), os.path.join('Tools', 'WebGPUAPIStructure')],

Alejandro G. Castro

Comment 26 2018-03-13 05:21:41 PDT

I can not find 36af4e9614f707f733eb2340fae66d6325aaac5b as a revision of the libwebrtc repository, is it maybe from another repository?

youenn fablet

Comment 27 2018-03-13 10:34:59 PDT

(In reply to Alejandro G. Castro from comment #25) > Consider adding this to remove the style checker to the libwebrtc repository: > > diff --git a/Tools/Scripts/webkitpy/style/checker.py > b/Tools/Scripts/webkitpy/style/checker.py > index 9b43879b841..0106ee301b9 100644 > --- a/Tools/Scripts/webkitpy/style/checker.py > +++ b/Tools/Scripts/webkitpy/style/checker.py > @@ -219,6 +219,7 @@ _PATH_RULES_SPECIFIER = [ > # > ([os.path.join('webkitpy', 'thirdparty'), > os.path.join('Source', 'ThirdParty', 'ANGLE'), > + os.path.join('Source', 'ThirdParty', 'libwebrtc'), > os.path.join('Source', 'ThirdParty', 'openvr'), > os.path.join('Source', 'ThirdParty', 'xdgmime'), > os.path.join('Tools', 'WebGPUAPIStructure')], Thanks, will do. (In reply to Alejandro G. Castro from comment #26) > I can not find 36af4e9614f707f733eb2340fae66d6325aaac5b as a revision of the > libwebrtc repository, is it maybe from another repository? This is the SHA identifying libwebrtc used in a Chrome stable branch. This no longer directly related to the libwebrtc repo. To get it, I do the following on chromium repo: gclient sync --with_branch_heads Then I checkout the branch I want.

youenn fablet

Comment 28 2018-03-13 14:24:52 PDT

Created attachment 335732 [details] Patch

EWS Watchlist

Comment 29 2018-03-13 14:30:14 PDT

Attachment 335732 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_types.h:104: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:48: The parameter name "window" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec3_fft.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/include/audio_processing_statistics.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:102: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/aec_state.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:24: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:26: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:55: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/matrix_buffer.h:57: One space before end of line comments [whitespace/comments] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.h:290: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:33: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 155, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 83, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 137, in process_file self._processor.process(lines, file_path, **kwargs) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 961, in process checker.check(lines) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 4024, in check self.handle_style_error, self.min_confidence) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3879, in _process_lines enum_state, asm_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3826, in process_line file_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3121, in check_language check_include_line(filename, file_extension, clean_lines, line_number, include_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3074, in check_include_line previous_header_type = include_state.header_types[previous_line_number] KeyError: 16 If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 30 2018-03-13 15:04:27 PDT

Created attachment 335737 [details] Patch

EWS Watchlist

Comment 31 2018-03-13 16:54:03 PDT

Attachment 335737 [details] did not pass style-queue: Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 155, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 83, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 137, in process_file self._processor.process(lines, file_path, **kwargs) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 962, in process checker.check(lines) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 4024, in check self.handle_style_error, self.min_confidence) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3879, in _process_lines enum_state, asm_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3826, in process_line file_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3121, in check_language check_include_line(filename, file_extension, clean_lines, line_number, include_state, error) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3074, in check_include_line previous_header_type = include_state.header_types[previous_line_number] KeyError: 16 If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 32 2018-03-14 09:18:29 PDT

Comment on attachment 335737 [details] Patch Yay!

WebKit Commit Bot

Comment 33 2018-03-14 10:43:38 PDT

Comment on attachment 335737 [details] Patch Clearing flags on attachment: 335737 Committed r229602: <https://trac.webkit.org/changeset/229602>

WebKit Commit Bot

Comment 34 2018-03-14 10:43:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.