Bug 183445

Summary:

[iOS] Unskip MathML tests requiring a font with Mathematical Alphanumeric Symbols

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

Tools / Tests

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, fred.wang, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

iOS 11

Bug Depends on:

177167

Bug Blocks:

160161

Attachments:

Description	Flags
Patch	commit-queue: commit-queue-

Description Frédéric Wang (:fredw) 2018-03-08 03:17:46 PST

It seems that iOS 11 now has a font with Mathematical Alphanumeric Symbols, so we could run the following tests: 

# These reftests require a font with Mathematical Alphanumeric Symbols.
mathml/presentation/attributes-mathvariant.html [ Skip ]
mathml/presentation/tokenElements-mathvariant.html [ Skip ]
mathml/presentation/mathvariant-inheritance.html [ Skip ]
mathml/presentation/mathvariant-tokens.html [ Skip ]

Comment 1 Frédéric Wang (:fredw) 2018-03-08 03:20:32 PST

Created attachment 335288 [details]
Patch

Comment 2 WebKit Commit Bot 2018-03-08 04:44:21 PST

Comment on attachment 335288 [details]
Patch

Rejecting attachment 335288 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335288, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
d0dbd8194e21b20ef130090445e38 41deb6944aac718c815689cde6b900e689fa9a7e M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.
Total errors found: 0 in 0 files

Full output: http://webkit-queues.webkit.org/results/6855374

Comment 3 Frédéric Wang (:fredw) 2018-03-08 04:48:52 PST

It looks like the commit-queue was able to commit the patch anyway: https://trac.webkit.org/changeset/229405/webkit

Comment 4 Radar WebKit Bug Importer 2018-03-08 04:49:21 PST

<rdar://problem/38258227>