Bug 18342

Summary:

Add logging to HTTP soup backend

Product:

WebKit

Reporter:

Xan Lopez <xan.lopez>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alp, danw, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
0001-Add-logging-to-http-soup-backend.patch	none
0001-Add-logging-to-http-soup-backend.patch	none
0001-Add-logging-to-http-soup-backend.patch	alp: review+

Xan Lopez

Reported 2008-04-07 07:56:09 PDT

Patch attached.

Attachments
0001-Add-logging-to-http-soup-backend.patch (2.26 KB, patch) 2008-04-07 07:57 PDT, Xan Lopez	no flags	Details Formatted Diff Diff
0001-Add-logging-to-http-soup-backend.patch (2.12 KB, patch) 2008-04-07 10:03 PDT, Xan Lopez	no flags	Details Formatted Diff Diff
0001-Add-logging-to-http-soup-backend.patch (2.10 KB, patch) 2008-04-07 10:05 PDT, Xan Lopez	alp: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Xan Lopez

Comment 1 2008-04-07 07:57:52 PDT

Created attachment 20381 [details] 0001-Add-logging-to-http-soup-backend.patch

Dan Winship

Comment 2 2008-04-07 09:50:16 PDT

You should unref the logger after attaching it to the session. (It doesn't really matter since the session is never destroyed anyway, so it doesn't actually cause a leak, but...) Any reason you used two environment variables instead of just one?

Xan Lopez

Comment 3 2008-04-07 10:03:10 PDT

(In reply to comment #2) > You should unref the logger after attaching it to the session. (It doesn't > really matter since the session is never destroyed anyway, so it doesn't > actually cause a leak, but...) Right, actually thought about that after sending the patch... fixed in the next patch anyway. > > Any reason you used two environment variables instead of just one? > Not really, might be handy if it could be changed at run-time, but I guess there is no point right now (and you could still manage with one variable anyway).

Xan Lopez

Comment 4 2008-04-07 10:03:31 PDT

Created attachment 20382 [details] 0001-Add-logging-to-http-soup-backend.patch

Xan Lopez

Comment 5 2008-04-07 10:05:16 PDT

Created attachment 20383 [details] 0001-Add-logging-to-http-soup-backend.patch Fix ChangeLog

Mark Rowe (bdash)

Comment 6 2008-04-07 10:36:42 PDT

What is the behaviour if I pass a value for WEBKIT_SOUP_LOGGING outside of the range 0-3?

Xan Lopez

Comment 7 2008-04-07 13:26:11 PDT

(In reply to comment #6) > What is the behaviour if I pass a value for WEBKIT_SOUP_LOGGING outside of the > range 0-3? > As far as I understand the code the value is checked progressively against 0/1/2 and if it's not equal it's assumed to be the maximum verbosity value. We can clamp it here or, maybe better, soup should warn about invalid values.

Alp Toker

Comment 8 2008-04-10 17:53:17 PDT

Comment on attachment 20383 [details] 0001-Add-logging-to-http-soup-backend.patch Think this is fine, no need to clamp. This will help debug the soup backend, r=me

Alp Toker

Comment 9 2008-04-10 17:55:36 PDT

Landed in r31792.

Note You need to log in before you can comment on or make changes to this bug.