Bug 183381

Summary: Web Automation: provide a way to ask clients for a new tab or window
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebDriverAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bburg, berto, cgarcia, ews-watchlist, gustavo, joepeck, mcatanzaro, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Fix
none
Proposed Fix (GTK v2)
none
Proposed Fix v2
none
Fix GTK/WPE none

Blaze Burg
Reported 2018-03-06 13:15:17 PST
This enables implementation of New Window / New Tab command. The spec discussion is here*; this is just the webkit-side changes to support this. * https://github.com/w3c/webdriver/issues/1138
Attachments
Proposed Fix (17.01 KB, patch)
2018-03-06 13:36 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (GTK v2) (17.13 KB, patch)
2018-03-06 14:15 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix v2 (20.13 KB, patch)
2018-03-24 11:27 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Fix GTK/WPE (20.39 KB, patch)
2018-03-26 11:52 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-03-06 13:15:32 PST
<rdar://problem/38167301>
Blaze Burg
Comment 2 2018-03-06 13:36:28 PST
Created attachment 335135 [details] Proposed Fix This needs to land with Safari-side changes. I haven't tested the GTK changes but they look trivial.
EWS Watchlist
Comment 3 2018-03-06 13:39:02 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Blaze Burg
Comment 4 2018-03-06 14:15:31 PST
Created attachment 335138 [details] Proposed Fix (GTK v2) Second attempt, let's use the same naming scheme for the options at Cocoa and namespace API levels to avoid confusing things.
Blaze Burg
Comment 5 2018-03-24 11:27:52 PDT
Created attachment 336478 [details] Proposed Fix v2
Blaze Burg
Comment 6 2018-03-26 11:52:02 PDT
Created attachment 336530 [details] Fix GTK/WPE
Blaze Burg
Comment 7 2018-03-26 12:26:00 PDT
Committed r229984: <https://trac.webkit.org/changeset/229984>
Note You need to log in before you can comment on or make changes to this bug.