Bug 183376

Summary:

AX: Flaky test after r229310

Product:

WebKit

Reporter:

Nan Wang <n_wang>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, n_wang, ryanhaddad, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=183023

Attachments:

Description	Flags
patch	cfleizach: review+, commit-queue: commit-queue-

Nan Wang

Reported 2018-03-06 11:47:55 PST

LayoutTest accessibility/mac/AOM-events.html is consistently crashing on High Sierra and timing out on Sierra after this change: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229323%20(3270)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2FAOM-events.html

Attachments
patch (4.31 KB, patch) 2018-03-06 12:01 PST, Nan Wang	cfleizach: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-03-06 11:48:11 PST

<rdar://problem/38188685>

Nan Wang

Comment 2 2018-03-06 12:01:22 PST

Created attachment 335124 [details] patch

Nan Wang

Comment 3 2018-03-06 13:37:22 PST

Hi Ryan, I have all green here but how can I tell if this patch won't cause flaky test on all the testing builds?

Ryan Haddad

Comment 4 2018-03-06 13:56:53 PST

(In reply to Nan Wang from comment #3) > Hi Ryan, > > I have all green here but how can I tell if this patch won't cause flaky > test on all the testing builds? Short of testing those configurations manually, we'll have to land the change and keep an eye on the bots.

WebKit Commit Bot

Comment 5 2018-03-06 14:49:32 PST

Comment on attachment 335124 [details] patch Rejecting attachment 335124 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335124, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: st, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. error: The last gc run reported the following. Please correct the root cause and remove /Volumes/Data/EWS/WebKit/.git/gc.log. Automatic cleanup will not be performed until the file is removed. warning: There are too many unreachable loose objects; run 'git prune' to remove them. Full output: http://webkit-queues.webkit.org/results/6832024

Nan Wang

Comment 6 2018-03-06 15:01:40 PST

Committed https://trac.webkit.org/changeset/229344/webkit

Note You need to log in before you can comment on or make changes to this bug.