Bug 183330 – [GTK][Wayland] The GTK Wayland bot exits early because of assertions related with libsecret since r221925

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

Since r221925 <https://trac.webkit.org/r221925> enabled G_DEBUG=fatal-criticals for the tests the GTK Wayland bot has been constantly crashing on many network-related tests.

The usual crash log is like this:

Thread 1 (Thread 0x7f6924feb3c0 (LWP 18364)):
#0  _g_log_abort () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:554
#1  0x00007f692d9b9415 in g_logv () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1362
#2  0x00007f692d9b9562 in g_log () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1403
#3  0x00007f692d72e1bc in search_closure_free (data=0x555b8bcf2040) at libsecret/secret-methods.c:54
#4  0x00007f692db4ce78 in clear_op_res () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:247
#5  g_simple_async_result_finalize () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:267
#6  0x00007f692da9444a in g_object_unref () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gobject.c:3330
#7  0x00007f692d72df94 in on_search_service (source=<optimized out>, result=0x555b8bc17ed0, user_data=<optimized out>) at libsecret/secret-methods.c:257
#8  0x00007f692db4db57 in g_simple_async_result_complete () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:801
#9  0x00007f692d7354ac in on_init_base (source=<optimized out>, result=0x7f68d000d6d0, user_data=<optimized out>) at libsecret/secret-service.c:692
#10 0x00007f692db5eb13 in g_task_return_now () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1145
#11 0x00007f692db5f5b6 in g_task_return () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1203
#12 0x00007f692db9b805 in get_connection_cb () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gdbusproxy.c:1827
#13 0x00007f692db5eb13 in g_task_return_now () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1145
#14 0x00007f692db5eb49 in complete_in_idle_cb () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1159
#15 0x00007f692d9b281a in g_main_dispatch () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148
#16 g_main_context_dispatch () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813
#17 0x00007f692d9b2ba8 in g_main_context_iterate () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886
#18 0x00007f692d9b2ec2 in g_main_loop_run () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082
#19 0x00007f6931da9670 in WTF::RunLoop::run() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#20 0x00007f6934328872 in NetworkProcessMainUnix () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#21 0x00007f692ab632b1 in __libc_start_main (main=0x555b89d9dd20 <main>, argc=3, argv=0x7ffead27f668, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffead27f658) at ../csu/libc-start.c:291
#22 0x0000555b89d9ddaa in _start ()


More details: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20Wayland%20(Tests)/r229257%20(5451)/results.html

[Carlos Alberto Lopez Perez]

The issue triggers here: https://sources.debian.org/src/libsecret/0.18.5-3.1/libsecret/secret-methods.c/#L54

Looking at master for libsecret it looks this might have been fixed already by Michael in https://bugzilla.gnome.org/show_bug.cgi?id=787391 ? 


Should we include libsecret in the jhbuild with that patch?

[Michael Catanzaro]

Yeah, might as well.

[Carlos Alberto Lopez Perez]

Created attachment 335005 [details]
Patch

[Michael Catanzaro]

Comment on attachment 335005 [details]
Patch

Eh, I did not realize that it was not already in the JHBuild... but OK, I guess, since getting the Wayland bot working again seems desirable

[Carlos Alberto Lopez Perez]

Comment on attachment 335005 [details]
Patch

Clearing flags on attachment: 335005

Committed r229290: <https://trac.webkit.org/changeset/229290>

[Carlos Alberto Lopez Perez]

All reviewed patches have been landed.  Closing bug.