Summary: | REGRESSION: Assertion failure in -[WebViewFactory endOfTextMarkerRange:] when invoking the Dictionary pop-up | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | Accessibility | Assignee: | Alice Liu <alice.barraclough> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alice.barraclough, ap, bdakin | ||||
Priority: | P2 | Keywords: | Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
mitz
2008-04-06 01:10:24 PDT
Created attachment 20401 [details]
patch
in AccessibilityObjectWrapper.mm, in -accessibilityAttributeValue:forParameter:, starting from the comment "// Convert values to WebCore types", we have a few lines of code that "prep" webcore equivalent values of mac-specific types. Although I'm not too fond of the idea of prepping these values in cases where they're not needed, having it all in one section makes the rest of the code easier to compare to what used to be in WebCoreAXObject.cpp, and thus easier for debugging in this transition period. Comment on attachment 20401 [details]
patch
Please add the bug URL and title to the change log.
+ if (textMarker != nil)
+ if (textMarkerRange != nil)
According to the style guidelines these should be written as
+ if (textMarker)
+ if (textMarkerRange)
r=me
(In reply to comment #2) > in AccessibilityObjectWrapper.mm, in > -accessibilityAttributeValue:forParameter:, starting from the comment "// > Convert values to WebCore types", we have a few lines of code that "prep" > webcore equivalent values of mac-specific types. Although I'm not too fond of > the idea of prepping these values in cases where they're not needed, having it > all in one section makes the rest of the code easier to compare to what used to > be in WebCoreAXObject.cpp, and thus easier for debugging in this transition > period. Just saw this comment. Perhaps you should add a FIXME or file a bug about improving that code in the future. |