Bug 183283

Summary: Make !ENABLE(DATA_DETECTION) iOS build actually succeed
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, aestes, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, saam, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+, commit-queue: commit-queue-

Tim Horton
Reported 2018-03-02 03:00:49 PST
Make !ENABLE(DATA_DETECTION) iOS build actually succeed
Attachments
Patch (4.94 KB, patch)
2018-03-02 03:01 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (10.91 KB, patch)
2018-03-02 10:44 PST, Tim Horton 		sam: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-03-02 03:01:07 PST
Created attachment 334889 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-03-02 03:03:13 PST
<rdar://problem/38062148>
Tim Horton
Comment 3 2018-03-02 10:44:48 PST
Created attachment 334908 [details] Patch
WebKit Commit Bot
Comment 4 2018-03-04 12:04:14 PST
Comment on attachment 334908 [details] Patch Rejecting attachment 334908 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334908, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6796493
Tim Horton
Comment 5 2018-03-04 23:03:19 PST
I think it retried and actually landed? https://trac.webkit.org/changeset/229205/webkit
Aakash Jain
Comment 6 2018-03-05 09:45:56 PST
Yes, it landed the commit. See: https://webkit-queues.webkit.org/results/6796493 It probably failed while clearing the flags on bug. This was due to network issue while talking to bugzilla. Should be fixed/improved in https://bugs.webkit.org/show_bug.cgi?id=183222
Note You need to log in before you can comment on or make changes to this bug.