Summary: | Implement createImageBitmap(Blob) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger> | ||||||||
Component: | Canvas | Assignee: | Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=178573 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 182424 | ||||||||||
Attachments: |
|
Description
Ms2ger (he/him; ⌚ UTC+1/+2)
2018-03-01 09:23:20 PST
Created attachment 334820 [details]
Patch
Created attachment 335080 [details]
Patch
Created attachment 335082 [details]
Patch
Comment on attachment 335082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335082&action=review > Source/WebCore/html/ImageBitmap.cpp:592 > +void ImageBitmap::createFromBuffer( > + Ref<ArrayBuffer>&& arrayBuffer, > + String mimeType, > + long long expectedContentLength, > + const URL& sourceUrl, > + ImageBitmapOptions&& options, > + std::optional<IntRect> rect, > + ImageBitmap::Promise&& promise) We normally just put everything on a single line Comment on attachment 335082 [details] Patch Clearing flags on attachment: 335082 Committed r230350: <https://trac.webkit.org/changeset/230350> All reviewed patches have been landed. Closing bug. |