Bug 183247

Summary: Implement createImageBitmap(Blob)
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: CanvasAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=178573
Bug Depends on:    
Bug Blocks: 182424    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Ms2ger (he/him; ⌚ UTC+1/+2) 2018-03-01 09:23:20 PST
.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-03-01 09:31:07 PST
Created attachment 334820 [details]
Patch
Comment 2 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-03-06 02:55:14 PST
Created attachment 335080 [details]
Patch
Comment 3 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-03-06 03:56:31 PST
Created attachment 335082 [details]
Patch
Comment 4 Dean Jackson 2018-04-06 11:30:11 PDT
Comment on attachment 335082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335082&action=review

> Source/WebCore/html/ImageBitmap.cpp:592
> +void ImageBitmap::createFromBuffer(
> +    Ref<ArrayBuffer>&& arrayBuffer,
> +    String mimeType,
> +    long long expectedContentLength,
> +    const URL& sourceUrl,
> +    ImageBitmapOptions&& options,
> +    std::optional<IntRect> rect,
> +    ImageBitmap::Promise&& promise)

We normally just put everything on a single line
Comment 5 WebKit Commit Bot 2018-04-06 12:33:37 PDT
Comment on attachment 335082 [details]
Patch

Clearing flags on attachment: 335082

Committed r230350: <https://trac.webkit.org/changeset/230350>
Comment 6 WebKit Commit Bot 2018-04-06 12:33:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-06 12:34:16 PDT
<rdar://problem/39245905>