| Summary: | Add a second tier of prevalence to facilitate telemetry on very prevalent domains | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||||
| Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, dbates, ews-watchlist, japhet, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=183233 https://bugs.webkit.org/show_bug.cgi?id=183950 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
John Wilander
2018-02-28 11:09:16 PST
I will use <rdar://problem/37992388> as the radar equivalent. Created attachment 334755 [details]
Patch
Comment on attachment 334755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334755&action=review r=me > Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp:37 > + return sqrt(a * a + b * b + c * c); This could probably be "std::hypot(a, b, c)", though I think this is known to be faster to execute. > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:532 > +{ ASSERT(isMainThread()); > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:547 > + resourceStatistic.isVeryPrevalentResource = true; resourceStatistic.isVeryPrevalentResource = newPrevlance == ResourceLoadPrevalence::VeryHigh; > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:576 > +{ ASSERT(isMainThread()); Comment on attachment 334755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334755&action=review >> Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp:37 >> + return sqrt(a * a + b * b + c * c); > > This could probably be "std::hypot(a, b, c)", though I think this is known to be faster to execute. I mean that YOUR code is known to be more efficient (if not as able to handle over/underflow). Comment on attachment 334755 [details] Patch Attachment 334755 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6708809 New failing tests: http/tests/preload/download_resources.html Created attachment 334763 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 334766 [details]
Patch for landing
Thanks, Brent! Fixed all the things you commented on. Comment on attachment 334766 [details] Patch for landing Clearing flags on attachment: 334766 Committed r229106: <https://trac.webkit.org/changeset/229106> All reviewed patches have been landed. Closing bug. Comment on attachment 334766 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=334766&action=review > Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp:55 > + ASSERT(currentPrevalence == Low); I am hitting this assertion in debug wk2. (In reply to Chris Dumez from comment #13) > Comment on attachment 334766 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334766&action=review > > > Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp:55 > > + ASSERT(currentPrevalence == Low); > > I am hitting this assertion in debug wk2. Thanks for the report, Chris. I removed the assertion in https://bugs.webkit.org/show_bug.cgi?id=183233. |