Bug 183178

Summary:

CSS ::selection stroke-color and stroke-width are not applied to selected text in text fields and ::selection:window-inactive stroke-color and stroke-width are never applied

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Layout and Rendering

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, ews-watchlist, hyatt, pvollan, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch and layout tests	none
Patch and layout tests	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews205 for win-future	none
Archive of layout-test-results from ews206 for win-future	none
Patch and layout tests	hyatt: review+

Daniel Bates

Reported 2018-02-27 14:13:51 PST

CSS ::selection stroke-color and stroke-width are not applied to selected text in text fields and ::selection:window-inactive stroke-color and stroke-width are never applied.

Attachments
Patch and layout tests (16.07 KB, patch) 2018-02-27 14:23 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and layout tests (20.19 KB, patch) 2018-02-27 14:33 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (5.69 MB, application/zip) 2018-02-27 15:52 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (12.85 MB, application/zip) 2018-02-27 16:38 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews206 for win-future (12.89 MB, application/zip) 2018-02-27 18:41 PST, EWS Watchlist	no flags	Details
Patch and layout tests (23.75 KB, patch) 2018-02-28 11:50 PST, Daniel Bates	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-02-27 14:23:05 PST

Created attachment 334705 [details] Patch and layout tests

Daniel Bates

Comment 2 2018-02-27 14:33:32 PST

Created attachment 334706 [details] Patch and layout tests

EWS Watchlist

Comment 3 2018-02-27 15:52:36 PST Comment hidden (obsolete)

Comment on attachment 334706 [details] Patch and layout tests Attachment 334706 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6696551 New failing tests: fast/selectors/text-field-selection-stroke-color.html fast/selectors/text-field-selection-window-inactive-text-shadow.html fast/selectors/selection-window-inactive-text-shadow.html fast/selectors/text-field-selection-window-inactive-stroke-color.html fast/selectors/selection-window-inactive-stroke-color.html fast/selectors/text-field-selection-text-shadow.html

EWS Watchlist

Comment 4 2018-02-27 15:52:38 PST Comment hidden (obsolete)

Created attachment 334711 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-02-27 16:38:12 PST Comment hidden (obsolete)

Comment on attachment 334706 [details] Patch and layout tests Attachment 334706 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6697264 New failing tests: fast/selectors/text-field-selection-stroke-color.html fast/selectors/text-field-selection-window-inactive-text-shadow.html fast/selectors/selection-window-inactive-text-shadow.html fast/selectors/text-field-selection-window-inactive-stroke-color.html fast/selectors/selection-window-inactive-stroke-color.html fast/selectors/text-field-selection-text-shadow.html

EWS Watchlist

Comment 6 2018-02-27 16:38:24 PST Comment hidden (obsolete)

Created attachment 334714 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 7 2018-02-27 18:41:11 PST Comment hidden (obsolete)

Comment on attachment 334706 [details] Patch and layout tests Attachment 334706 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6698969 New failing tests: fast/selectors/text-field-selection-stroke-color.html fast/selectors/text-field-selection-window-inactive-text-shadow.html fast/selectors/selection-window-inactive-text-shadow.html http/tests/preload/download_resources.html fast/selectors/text-field-selection-window-inactive-stroke-color.html fast/selectors/selection-window-inactive-stroke-color.html fast/selectors/text-field-selection-text-shadow.html

EWS Watchlist

Comment 8 2018-02-27 18:41:22 PST Comment hidden (obsolete)

Created attachment 334722 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Daniel Bates

Comment 9 2018-02-28 11:50:35 PST

Created attachment 334756 [details] Patch and layout tests

Dave Hyatt

Comment 10 2018-03-01 10:16:51 PST

Comment on attachment 334756 [details] Patch and layout tests r=me

Daniel Bates

Comment 11 2018-03-01 14:35:51 PST

Committed r229147: <https://trac.webkit.org/changeset/229147>

Radar WebKit Bug Importer

Comment 12 2018-03-01 14:38:24 PST

<rdar://problem/38041014>

Note You need to log in before you can comment on or make changes to this bug.