| Summary: | [Win][DRT] Implement setSpatialNavigationEnabled. | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, don.olmstead, ews-watchlist, pvollan, stephan.szabo, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=183177 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Ross Kirsling
2018-02-27 11:42:20 PST
Created attachment 334697 [details]
Patch
I'm just focusing on WinCairo here, but let me know if you'd like me to remove the Skip line from AppleWin TestExpectations as well: https://github.com/WebKit/webkit/blob/master/LayoutTests/platform/win/TestExpectations#L228-L229 Created attachment 334704 [details]
Patch
Comment on attachment 334704 [details]
Patch
...figured if I was going to bother to mention it, I should just go ahead and do it.
The WinCairo failure here is a CMake fluke (no code was changed from the previous patch); I've made a bug for it here: https://bugs.webkit.org/show_bug.cgi?id=183177 Comment on attachment 334704 [details] Patch Attachment 334704 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6695928 New failing tests: fast/spatial-navigation/snav-multiple-select-focusring.html Created attachment 334707 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 334708 [details]
Patch
Comment on attachment 334708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334708&action=review > Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:123 > + HRESULT isSpatialNavigationEnabled([out, retval] BOOL *enabled); > + HRESULT setSpatialNavigationEnabled([in] BOOL enabled); I think you need to add this to the end of IWebPreferencesPrivate6, or create IWebPreferencesPrivate7, and add these methods there. Created attachment 334754 [details]
Patch
Created attachment 334765 [details]
Patch
Thanks, I think this should be correct now. Comment on attachment 334765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334765&action=review > Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:224 > + HRESULT isSpatialNavigationEnabled([out, retval] BOOL *enabled); I think we usually would use 'spatialNavigationEnabled()' here. (In reply to Per Arne Vollan from comment #13) > Comment on attachment 334765 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334765&action=review > > > Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:224 > > + HRESULT isSpatialNavigationEnabled([out, retval] BOOL *enabled); > > I think we usually would use 'spatialNavigationEnabled()' here. I was just mimicking "isXSSAuditorEnabled", but I'm happy to do either. Created attachment 334828 [details]
Patch
Comment on attachment 334828 [details]
Patch
R=me as long as ews is green.
(In reply to Per Arne Vollan from comment #16) > Comment on attachment 334828 [details] > Patch > > R=me as long as ews is green. On WinCairo we seem to be hitting https://bugs.webkit.org/show_bug.cgi?id=183177 with this patch. We're fine with landing it as is. Comment on attachment 334828 [details] Patch Clearing flags on attachment: 334828 Committed r229143: <https://trac.webkit.org/changeset/229143> All reviewed patches have been landed. Closing bug. |