Bug 183134 – Regression(r223431): Crash under didReceiveChallenge in NetworkSessionCocoa

• Component: Page Loading
• Status: RESOLVED FIXED

[Chris Dumez]

Crash under didReceiveChallenge in NetworkSessionCocoa:
Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x0000000000000060)
[  0] 0x000000019207933c WebKit`WTF::KeyValuePair<unsigned long long, WebKit::DownloadID>* WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WebKit::DownloadID>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WebKit::DownloadID> >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::lookup<WTF::HashMapTranslatorAdapter<WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::IntHash<unsigned long long> > >, unsigned long long>(unsigned long long const&) [inlined] WTF::KeyValuePair<unsigned long long, WebKit::DownloadID>* WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WebKit::DownloadID>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WebKit::DownloadID> >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::inlineLookup<WTF::HashMapTranslatorAdapter<WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::IntHash<unsigned long long> > >, unsigned long long>(unsigned long long const&) at HashTable.h:612:28

 ->  0x000000019207933c:      ldr x8, [x0]
     0x0000000192079340:      cbz x8, 0xeb3dc          ; <+160> at HashTable.h
     0x0000000192079344:      ldr w9, [x0, #0xc]
     0x0000000192079348:      ldr x10, [x1]
     0x000000019207934c:      mov x11, #-0x1

[  0] 0x000000019207933c WebKit`WTF::KeyValuePair<unsigned long long, WebKit::DownloadID>* WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WebKit::DownloadID>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WebKit::DownloadID> >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::lookup<WTF::HashMapTranslatorAdapter<WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::IntHash<unsigned long long> > >, unsigned long long>(unsigned long long const&) at HashTable.h:601
[  1] 0x00000001920764e7 WebKit`::-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:](NSURLSession *, NSURLSessionTask *, NSURLAuthenticationChallenge *, void (^)(NSURLSessionAuthChallengeDisposition, NSURLCredential *)) [inlined] WebKit::DownloadID WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::get<WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::KeyValuePairTraits, WTF::IntHash<unsigned long long> >, unsigned long long>(unsigned long long const&) const + 11 at HashMap.h:307:63
[  1] 0x00000001920764dc WebKit`::-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:](NSURLSession *, NSURLSessionTask *, NSURLAuthenticationChallenge *, void (^)(NSURLSessionAuthChallengeDisposition, NSURLCredential *)) [inlined] WTF::HashMap<unsigned long long, WebKit::DownloadID, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::DownloadID> >::get(unsigned long long const&) const at HashMap.h:422
[  1] 0x00000001920764dc WebKit`::-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:](NSURLSession *, NSURLSessionTask *, NSURLAuthenticationChallenge *, void (^)(NSURLSessionAuthChallengeDisposition, NSURLCredential *)) [inlined] WebKit::NetworkSessionCocoa::downloadID(unsigned long long) at NetworkSessionCocoa.mm:753
[  1] 0x00000001920764dc WebKit`::-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:](NSURLSession *, NSURLSessionTask *, NSURLAuthenticationChallenge *, void (^)(NSURLSessionAuthChallengeDisposition, NSURLCredential *)) + 656 at NetworkSessionCocoa.mm:347
[  2] 0x00000001829c8697 Foundation`__NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ + 15 at NSOperation.m:1467:5
[  3] 0x000000018290842f Foundation`-[NSBlockOperation main] + 71 at NSOperation.m:1486:9
[  4] 0x00000001828f8017 Foundation`-[__NSOperationInternal _start:] + 847 at NSOperation.m:830:13
[  5] 0x00000001818b0a2b libdispatch.dylib`_dispatch_client_callout + 15 at object.m:507:10
[  6] 0x00000001818ecaab libdispatch.dylib`_dispatch_block_invoke_direct$VARIANT$armv81 + 215 at queue.c:3022:2
[  7] 0x00000001818b0a2b libdispatch.dylib`_dispatch_client_callout + 15 at object.m:507:10
[  8] 0x00000001818ecaab libdispatch.dylib`_dispatch_block_invoke_direct$VARIANT$armv81 + 215 at queue.c:3022:2
[  9] 0x00000001818ec99f libdispatch.dylib`dispatch_block_perform$VARIANT$armv81 + 103 at queue.c:2994:9
[ 10] 0x00000001829ca27f Foundation`__NSOQSchedule_f + 375 at NSOperation.m:2086:13
[ 11] 0x00000001818b0a2b libdispatch.dylib`_dispatch_client_callout + 15 at object.m:507:10
[ 12] 0x00000001818f1cff libdispatch.dylib`_dispatch_main_queue_callback_4CF$VARIANT$armv81 [inlined] _dispatch_continuation_invoke_inline + 275 at inline_internal.h:2500:2
[ 12] 0x00000001818f1bec libdispatch.dylib`_dispatch_main_queue_callback_4CF$VARIANT$armv81 [inlined] _dispatch_continuation_pop_inline + 60 at inline_internal.h:2541
[ 12] 0x00000001818f1bb0 libdispatch.dylib`_dispatch_main_queue_callback_4CF$VARIANT$armv81 [inlined] _dispatch_main_queue_drain + 576 at queue.c:5170
[ 12] 0x00000001818f1970 libdispatch.dylib`_dispatch_main_queue_callback_4CF$VARIANT$armv81 + 52 at queue.c:6671
[ 13] 0x0000000181f5868f CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 11 at CFRunLoop.c:1815:5
[ 14] 0x0000000181f561e7 CoreFoundation`__CFRunLoopRun + 2271 at CFRunLoop.c:3111:13
[ 15] 0x0000000181e765d7 CoreFoundation`CFRunLoopRunSpecific + 551 at CFRunLoop.c:3245:18
[ 16] 0x00000001828ec103 Foundation`-[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 303 at NSRunLoop.m:367:5
[ 17] 0x000000018293dd6b Foundation`-[NSRunLoop(NSRunLoop) run] + 87 at NSRunLoop.m:389:12
[ 18] 0x0000000181c22cb8 _xpc_objc_main + 516 (main.m:167)
[ 19] 0x0000000181c24d8c xpc_main + 180 (init.c:1476)
[ 20] 0x000000010423f5ac main + 380 (XPCServiceMain.mm:148)
[ 21] 0x0000000181915faf libdyld.dylib`start + 3

[Chris Dumez]

<rdar://problem/36339049>

[Radar WebKit Bug Importer]

<rdar://problem/37906041>

[Chris Dumez]

Created attachment 334627 [details]
Patch

[Chris Dumez]

Comment on attachment 334627 [details]
Patch

Clearing flags on attachment: 334627

Committed r229031: <https://trac.webkit.org/changeset/229031>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.