Summary: | [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | WebKitGTK | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, commit-queue, svillar, zan | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 145121 | ||||||
Attachments: |
|
Description
Fujii Hironori
2018-02-25 20:35:21 PST
This is configurable by the option USE_LIBCXX. https://trac.webkit.org/browser/webkit/trunk/Source/ThirdParty/openvr/CMakeLists.txt?rev=227518#L7 > option(USE_LIBCXX "Uses libc++ instead of libstdc++" ON) Created attachment 334590 [details]
Patch
Comment on attachment 334590 [details]
Patch
LGTM. I guess the whole "Enable some properties" section could be removed in the future.
Comment on attachment 334590 [details] Patch Clearing flags on attachment: 334590 Committed r228985: <https://trac.webkit.org/changeset/228985> All reviewed patches have been landed. Closing bug. |