Bug 183080

Summary: Make LibWebRTCProvider port agnostic again after r215424
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebRTCAssignee: Alejandro G. Castro <alex>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183244    
Bug Blocks: 178860    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Alejandro G. Castro
Reported 2018-02-23 05:21:13 PST
In that commit the webRTCAvailable function started to use a function from the DARWIN platform.
Attachments
Patch (6.32 KB, patch)
2018-02-23 05:30 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (6.22 KB, patch)
2018-02-23 05:47 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (6.63 KB, patch)
2018-02-23 06:49 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (6.82 KB, patch)
2018-02-26 01:52 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (8.01 KB, patch)
2018-02-26 02:41 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (8.02 KB, patch)
2018-02-26 02:53 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (7.85 KB, patch)
2018-02-26 03:28 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (8.11 KB, patch)
2018-02-28 03:46 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.64 KB, patch)
2018-03-01 04:50 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (6.72 KB, patch)
2018-03-01 06:15 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (7.68 KB, patch)
2018-03-01 06:28 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (7.66 KB, patch)
2018-03-01 06:38 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.66 KB, patch)
2018-03-02 00:46 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2018-02-23 05:30:30 PST
Created attachment 334522 [details] Patch
Alejandro G. Castro
Comment 2 2018-02-23 05:47:47 PST
Created attachment 334523 [details] Patch
Alejandro G. Castro
Comment 3 2018-02-23 06:49:48 PST
Created attachment 334527 [details] Patch
Alejandro G. Castro
Comment 4 2018-02-26 01:52:39 PST
Created attachment 334599 [details] Patch
Alejandro G. Castro
Comment 5 2018-02-26 02:41:48 PST
Created attachment 334601 [details] Patch
Alejandro G. Castro
Comment 6 2018-02-26 02:53:15 PST
Created attachment 334602 [details] Patch
Alejandro G. Castro
Comment 7 2018-02-26 03:28:15 PST
Created attachment 334604 [details] Patch
Alejandro G. Castro
Comment 8 2018-02-28 03:46:42 PST
Created attachment 334736 [details] Patch
youenn fablet
Comment 9 2018-02-28 10:46:39 PST
Comment on attachment 334736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334736&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:49 > +#if PLATFORM(COCOA) We probably want to keep the case of COCOA platform that would not use libwebrtc for now. So we probably want to keep the USE(LIBWEBRTC) check here. Can we move this implementation of LibWebRTCProvider::create to LibWebRTCProviderCocoa.cpp as is? That could remove the need to update LibWebRTCProviderCocoa class.
Alejandro G. Castro
Comment 10 2018-03-01 02:40:42 PST
(In reply to youenn fablet from comment #9) > Comment on attachment 334736 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334736&action=review > > > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:49 > > +#if PLATFORM(COCOA) > > We probably want to keep the case of COCOA platform that would not use > libwebrtc for now. > So we probably want to keep the USE(LIBWEBRTC) check here. > Right, I'll kepp that. > Can we move this implementation of LibWebRTCProvider::create to > LibWebRTCProviderCocoa.cpp as is? > That could remove the need to update LibWebRTCProviderCocoa class. I'll try it. Thanks for the review!
Alejandro G. Castro
Comment 11 2018-03-01 04:50:44 PST
Created attachment 334806 [details] Patch for landing
WebKit Commit Bot
Comment 12 2018-03-01 05:27:28 PST
Comment on attachment 334806 [details] Patch for landing Clearing flags on attachment: 334806 Committed r229130: <https://trac.webkit.org/changeset/229130>
WebKit Commit Bot
Comment 13 2018-03-01 05:27:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2018-03-01 05:28:35 PST
<rdar://problem/38023990>
WebKit Commit Bot
Comment 15 2018-03-01 05:53:47 PST
Re-opened since this is blocked by bug 183244
Alejandro G. Castro
Comment 16 2018-03-01 06:15:33 PST
Created attachment 334813 [details] Patch
Alejandro G. Castro
Comment 17 2018-03-01 06:24:40 PST
Moving the LibWebRTCProvider:create out of the provider file caused the compilation issues for the platforms that are not using glib or cocoa. I'm adding it with an ifdef for the other platforms to try to fix it.
Alejandro G. Castro
Comment 18 2018-03-01 06:28:17 PST
Created attachment 334814 [details] Patch
Alejandro G. Castro
Comment 19 2018-03-01 06:38:35 PST
Created attachment 334816 [details] Patch
Alejandro G. Castro
Comment 20 2018-03-02 00:46:42 PST
Created attachment 334884 [details] Patch for landing
WebKit Commit Bot
Comment 21 2018-03-02 01:23:14 PST
Comment on attachment 334884 [details] Patch for landing Clearing flags on attachment: 334884 Committed r229169: <https://trac.webkit.org/changeset/229169>
WebKit Commit Bot
Comment 22 2018-03-02 01:23:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.