Summary: | Release assertion in WebPage::updatePreferences | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
Component: | WebKit2 | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, beidson, cdumez, commit-queue, mitz, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2018-02-22 23:25:26 PST
Created attachment 334506 [details]
Patch
Created attachment 334568 [details]
Patch
Comment on attachment 334568 [details] Patch r=me with non sw-enabled build fix. View in context: https://bugs.webkit.org/attachment.cgi?id=334568&action=review > Source/WebKit/StorageProcess/StorageProcess.cpp:191 > + return; The work done here seems harmless so maybe we can do it anyway, especially since we are disabling any IPC to Messages::WebSWServerToContextConnection? I am not familiar with this routine but maybe there is a chance for a race condition somehow so that we initialize the website data store first and get the entitlement later on. *** This bug has been marked as a duplicate of bug 183135 *** Comment on attachment 334568 [details]
Patch
lgtm too.
Reopening to attach new patch. Created attachment 334631 [details]
Patch for landing
Comment on attachment 334631 [details]
Patch for landing
Wait for EWS.
*** Bug 183135 has been marked as a duplicate of this bug. *** Comment on attachment 334568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334568&action=review >> Source/WebKit/StorageProcess/StorageProcess.cpp:191 >> + return; > > The work done here seems harmless so maybe we can do it anyway, especially since we are disabling any IPC to Messages::WebSWServerToContextConnection? > I am not familiar with this routine but maybe there is a chance for a race condition somehow so that we initialize the website data store first and get the entitlement later on. We need this check to disable service worker in the storage process. Created attachment 334634 [details]
Patch for landing
Committed r229037: <https://trac.webkit.org/changeset/229037> |