Bug 183062

Summary:

Caches::initialize should call all pending initialization callbacks in case of error

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, cgarcia, commit-queue, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=183068

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description youenn fablet 2018-02-22 13:54:33 PST

Currently, it is only doing so for the first callback

Comment 1 youenn fablet 2018-02-22 13:58:40 PST

Created attachment 334476 [details]
Patch

Comment 2 youenn fablet 2018-02-22 13:59:41 PST

Created attachment 334477 [details]
Patch

Comment 3 youenn fablet 2018-02-22 14:01:00 PST

Created attachment 334478 [details]
Patch

Comment 4 WebKit Commit Bot 2018-02-22 14:53:46 PST

Comment on attachment 334478 [details]
Patch

Clearing flags on attachment: 334478

Committed r228936: <https://trac.webkit.org/changeset/228936>

Comment 5 WebKit Commit Bot 2018-02-22 14:53:47 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-02-22 14:54:41 PST

<rdar://problem/37803485>

Comment 7 Ryosuke Niwa 2018-02-22 16:17:51 PST

Why didn't this patch have tests?

Comment 8 youenn fablet 2018-02-22 16:21:35 PST

(In reply to Ryosuke Niwa from comment #7)
> Why didn't this patch have tests?

These errors typically happen when there is a failure to read or write from disk.
We do not have a way to emulate or trigger these errors.

In addition, this is time sensitive since the app needs to try opening the same Caches twice from different frames/tabs at the same time to face that issue.