Bug 183062

Summary: Caches::initialize should call all pending initialization callbacks in case of error
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, commit-queue, ews-watchlist, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=183068
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2018-02-22 13:54:33 PST
Currently, it is only doing so for the first callback
Attachments
Patch (1.94 KB, patch)
2018-02-22 13:58 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2018-02-22 13:59 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.98 KB, patch)
2018-02-22 14:01 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-02-22 13:58:40 PST
Created attachment 334476 [details] Patch
youenn fablet
Comment 2 2018-02-22 13:59:41 PST
Created attachment 334477 [details] Patch
youenn fablet
Comment 3 2018-02-22 14:01:00 PST
Created attachment 334478 [details] Patch
WebKit Commit Bot
Comment 4 2018-02-22 14:53:46 PST
Comment on attachment 334478 [details] Patch Clearing flags on attachment: 334478 Committed r228936: <https://trac.webkit.org/changeset/228936>
WebKit Commit Bot
Comment 5 2018-02-22 14:53:47 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-02-22 14:54:41 PST
<rdar://problem/37803485>
Ryosuke Niwa
Comment 7 2018-02-22 16:17:51 PST
Why didn't this patch have tests?
youenn fablet
Comment 8 2018-02-22 16:21:35 PST
(In reply to Ryosuke Niwa from comment #7) > Why didn't this patch have tests? These errors typically happen when there is a failure to read or write from disk. We do not have a way to emulate or trigger these errors. In addition, this is time sensitive since the app needs to try opening the same Caches twice from different frames/tabs at the same time to face that issue.
Note You need to log in before you can comment on or make changes to this bug.