Bug 183059 – ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition

• Component: Page Loading
• Status: RESOLVED FIXED

[Chris Dumez]

ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition.

[Radar WebKit Bug Importer]

<rdar://problem/37800202>

[Chris Dumez]

Created attachment 334473 [details]
Patch

[Chris Dumez]

I suspect it could explain this crash:
Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x00007fff32be44c0 WTF::StringImpl::~StringImpl() + 80
1   com.apple.JavaScriptCore      	0x00007fff32be445e WTF::StringImpl::destroy(WTF::StringImpl*) + 14
2   com.apple.WebCore             	0x00007fff3d256e73 WebCore::ResourceRequestBase::operator=(WebCore::ResourceRequestBase const&) + 227
3   com.apple.WebCore             	0x00007fff3e148c9e WTF::Function<void (WebCore::ResourceRequest&&)>::CallableWrapper<WebCore::ResourceLoader::init(WebCore::ResourceRequest&&, WTF::CompletionHandler<void (bool)>&&)::$_1>::call(WebCore::ResourceRequest&&) + 142
4   com.apple.WebCore             	0x00007fff3e1512e4 WTF::Function<void (WebCore::ResourceRequest&&)>::CallableWrapper<WebCore::SubresourceLoader::willSendRequestInternal(WebCore::ResourceRequest&&, WebCore::ResourceResponse const&, WTF::CompletionHandler<void (WebCore::ResourceRequest&&)>&&)::$_0::operator()(WTF::CompletionHandler<void (WebCore::ResourceRequest&&)>&&, WebCore::ResourceRequest&&)::'lambda'(WebCore::ResourceRequest&&)>::call(WebCore::ResourceRequest&&) + 116
5   com.apple.WebCore             	0x00007fff3e145973 WebCore::ResourceLoader::willSendRequestInternal(WebCore::ResourceRequest&&, WebCore::ResourceResponse const&, WTF::CompletionHandler<void (WebCore::ResourceRequest&&)>&&) + 1891
6   com.apple.WebCore             	0x00007fff3e14d4b4 WebCore::SubresourceLoader::willSendRequestInternal(WebCore::ResourceRequest&&, WebCore::ResourceResponse const&, WTF::CompletionHandler<void (WebCore::ResourceRequest&&)>&&)::$_0::operator()(WTF::CompletionHandler<void (WebCore::ResourceRequest&&)>&&, WebCore::ResourceRequest&&) + 420
7   com.apple.WebCore             	0x00007fff3e14bc86 WebCore::SubresourceLoader::willSendRequestInternal(WebCore::ResourceRequest&&, WebCore::ResourceResponse const&, WTF::CompletionHandler<void (WebCore::ResourceRequest&&)>&&) + 358
8   com.apple.WebCore             	0x00007fff3e144c5c WebCore::ResourceLoader::init(WebCore::ResourceRequest&&, WTF::CompletionHandler<void (bool)>&&) + 396
9   com.apple.WebCore             	0x00007fff3e14ba36 WebCore::SubresourceLoader::create(WebCore::Frame&, WebCore::CachedResource&, WebCore::ResourceRequest&&, WebCore::ResourceLoaderOptions const&, WTF::CompletionHandler<void (WTF::RefPtr<WebCore::SubresourceLoader, WTF::DumbPtrTraits<WebCore::SubresourceLoader> >&&)>&&) + 166
10  com.apple.WebKit              	0x00007fff3ed00105 WebKit::WebLoaderStrategy::loadResource(WebCore::Frame&, WebCore::CachedResource&, WebCore::ResourceRequest&&, WebCore::ResourceLoaderOptions const&, WTF::CompletionHandler<void (WTF::RefPtr<WebCore::SubresourceLoader, WTF::DumbPtrTraits<WebCore::SubresourceLoader> >&&)>&&) + 169
11  com.apple.WebCore             	0x00007fff3e16d86c WebCore::CachedResource::load(WebCore::CachedResourceLoader&) + 2860
12  com.apple.WebCore             	0x00007fff3e1749ae WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&, WebCore::CachedResourceLoader::ForPreload, WebCore::CachedResourceLoader::DeferOption) + 6510
13  com.apple.WebCore             	0x00007fff3e175ece WebCore::CachedResourceLoader::requestRawResource(WebCore::CachedResourceRequest&&) + 46
14  com.apple.WebCore             	0x00007fff3e113c97 WebCore::DocumentThreadableLoader::loadRequest(WebCore::ResourceRequest&&, WebCore::SecurityCheckPolicy) + 1047
15  com.apple.WebCore             	0x00007fff3e11369d WebCore::DocumentThreadableLoader::DocumentThreadableLoader(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::DocumentThreadableLoader::BlockingBehavior, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::RefPtr<WebCore::SecurityOrigin, WTF::DumbPtrTraits<WebCore::SecurityOrigin> >&&, std::__1::unique_ptr<WebCore::ContentSecurityPolicy, std::__1::default_delete<WebCore::ContentSecurityPolicy> >&&, WTF::String&&, WebCore::DocumentThreadableLoader::ShouldLogError) + 1085
16  com.apple.WebCore             	0x00007fff3e113089 WebCore::DocumentThreadableLoader::create(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::RefPtr<WebCore::SecurityOrigin, WTF::DumbPtrTraits<WebCore::SecurityOrigin> >&&, std::__1::unique_ptr<WebCore::ContentSecurityPolicy, std::__1::default_delete<WebCore::ContentSecurityPolicy> >&&, WTF::String&&, WebCore::DocumentThreadableLoader::ShouldLogError) + 89
17  com.apple.WebCore             	0x00007fff3e151832 WTF::Function<void (WebCore::ScriptExecutionContext&)>::CallableWrapper<WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge(WebCore::ThreadableLoaderClientWrapper&, WebCore::WorkerLoaderProxy&, WTF::String const&, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::String const&, WebCore::WorkerGlobalScope&)::$_5>::call(WebCore::ScriptExecutionContext&) + 98
18  com.apple.JavaScriptCore      	0x00007fff32c23160 WTF::dispatchFunctionsFromMainThread() + 176

[WebKit Commit Bot]

Comment on attachment 334473 [details]
Patch

Clearing flags on attachment: 334473

Committed r228934: <https://trac.webkit.org/changeset/228934>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.