Bug 183048 – The WebContent process should not use NSScreen in the screenDepth implementation.

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Per Arne Vollan]

NSScreen method calls should be done in the UIProcess, since these calls will communicate with the WindowServer.

[Radar WebKit Bug Importer]

<rdar://problem/37795231>

[Per Arne Vollan]

Created attachment 334461 [details]
Patch

[Per Arne Vollan]

Created attachment 334464 [details]
Patch

[Brent Fulgham]

Comment on attachment 334464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334464&action=review

This patch looks good, but I think it would be better if you got rid of the duplicated code. Can you please revise that?

> Source/WebCore/platform/mac/PlatformScreenMac.mm:140
> +        return screenProperties().get(iter->key).screenDepth;

This snippet of logic is also in 'screenRect' and 'screenAvailableRect', (and perhaps others?). Can you encapsulate it in a common function that returns the appropriate screenProperties, then each of these methods can just return the member we are interested in?

Also: Should we ASSERT if the depth is zero, just in case the IPC didn't happen for some reason?

[Per Arne Vollan]

Created attachment 334469 [details]
Patch

[Per Arne Vollan]

Created attachment 334470 [details]
Patch

[Brent Fulgham]

Comment on attachment 334470 [details]
Patch

Looks great! r=me.

[Per Arne Vollan]

Comment on attachment 334470 [details]
Patch

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 334470 [details]
Patch

Clearing flags on attachment: 334470

Committed r228940: <https://trac.webkit.org/changeset/228940>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.