| Summary: | [GTK] Rendering issue with Google Calendar notification details | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Alejandro G. Castro <alex> | ||||||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||||||
| Severity: | Normal | CC: | bugs-noreply, cadubentzen, cgarcia, clopez, magomez, mcatanzaro, otte | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | Other | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 334446 [details]
Firefox rendering
This happens with 2.19.90. Created attachment 334811 [details]
Patch
Comment on attachment 334811 [details]
Patch
I added the patch here by mistake, sorry.
Actually I can see the rendering messed up in the whole page, and even a crash sometimes, with minibrowser and ToT Created attachment 339810 [details]
Test to reproduce
The test attached reproduces the situation here on Epiphany nightly and Minibrowser.
The problem is the SpinButton from GTK theme which has pretty large dimensions, so to work around this, the GTK port resizes the text field element (or at least tries to) to avoid cases like this that hide the text field area. However, in some cases the resize doesn't work, like in Google Calendar notification example and the isolated reproduction.
To continue using the GTK themes in those cases we could override RenderTheme::shouldHaveSpinButton to not draw the spinbuttons in those cases, I think. Otherwise, what about dropping the spinbutton from GTK and draw arrows like Firefox/Chromium does? (I think prior to GTK 3.20.0 it was doing it)
Created attachment 339811 [details]
Test to reproduce
Ops, I sent a wrong attachment. This is the right one.
(In reply to Carlos Eduardo Ramalho from comment #6) > To continue using the GTK themes in those cases we could override > RenderTheme::shouldHaveSpinButton to not draw the spinbuttons in those > cases, I think. Otherwise, what about dropping the spinbutton from GTK and > draw arrows like Firefox/Chromium does? (I think prior to GTK 3.20.0 it was > doing it) Either option seems OK. Using the GTK theme where possible is nicer and more desirable... but we'd need to be confident that it's not going to break websites like this. This is bug #175067. *** This bug has been marked as a duplicate of bug 175067 *** |
Created attachment 334445 [details] Screenshot Steps: 1. Open Google Calendar 2. Open the details of an event 3. Check the notifications