Bug 182991

Summary: ASSERT under WebAutomationSession::setProcessPool() when running W3C test suite a second time
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebDriverAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bburg, cgarcia, commit-queue, ews-watchlist, joepeck, mkwst, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2018-02-20 17:13:24 PST
It appears that the WebProcessPool's WebAutomationSession did not get cleared properly before we set the next one. Thus, we hit this assertion: #1 0x000000010f8cf13e in IPC::MessageReceiverMap::addMessageReceiver(IPC::StringReference, IPC::MessageReceiver&) at /Users/bburg/repos/webkit/OpenSource/Source/WebKit/Platform/IPC/MessageReceiverMap.cpp:44 ASSERT(!m_globalMessageReceivers.contains(messageReceiverName)); Because the old session has still registered for the name "WebAutomationSession". I looked into the receiver map and saw some unrecognized pointer still registered for that name. So, my hunch is that it's an old session that wasn't cleared properly. In general, the existing pattern of relying on the destructor to run at a certain time and clean up message receivers seems bad. If the client accidentally retained the WebAutomationSession somehow, then this would behave poorly.
Attachments
Proposed Fix (3.01 KB, patch)
2018-02-20 17:20 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-02-20 17:13:45 PST
<rdar://problem/37620578>
Blaze Burg
Comment 2 2018-02-20 17:20:39 PST
Created attachment 334324 [details] Proposed Fix
Timothy Hatcher
Comment 3 2018-02-20 17:23:08 PST
Comment on attachment 334324 [details] Proposed Fix Good call. I blame me.
WebKit Commit Bot
Comment 4 2018-02-20 18:18:02 PST
Comment on attachment 334324 [details] Proposed Fix Clearing flags on attachment: 334324 Committed r228854: <https://trac.webkit.org/changeset/228854>
WebKit Commit Bot
Comment 5 2018-02-20 18:18:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.