Summary: | [Curl] Fix warning on clang. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
Component: | WebCore Misc. | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, annulen, Basuke.Suzuki, bfulgham, commit-queue, don.olmstead, ews-watchlist, galpeter, pvollan, rniwa, webkit-bug-importer, youennf, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Basuke Suzuki
2018-02-20 15:01:29 PST
Created attachment 334305 [details]
Fix
Comment on attachment 334305 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=334305&action=review > Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h:-52 > - void deref(); If there is no class inheriting from CurlResourceHandleDelegate, add "final" specifier to class declaration and methods Comment on attachment 334305 [details] Fix Attachment 334305 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6596590 New failing tests: http/wpt/resource-timing/rt-initiatorType-media.html Created attachment 334322 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 334396 [details]
fix
Fix to use final instead of override and add final onto the class definition.
(In reply to Konstantin Tokarev from comment #2) > Comment on attachment 334305 [details] > Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334305&action=review > > > Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h:-52 > > - void deref(); > > If there is no class inheriting from CurlResourceHandleDelegate, add "final" > specifier to class declaration and methods Okay, got it. Comment on attachment 334396 [details] fix Clearing flags on attachment: 334396 Committed r228927: <https://trac.webkit.org/changeset/228927> All reviewed patches have been landed. Closing bug. |