Bug 18295
| Summary: | Include major OS revision in user agent | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tom <me.at.work> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | VERIFIED WORKSFORME | ||
| Severity: | Enhancement | CC: | gavin.sharp, jruderman |
| Priority: | P3 | ||
| Version: | 525.x (Safari 3.1) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
| URL: | https://bugzilla.mozilla.org/show_bug.cgi?id=400089 | ||
Tom
Version 3.1 (5525.13)
To achieve parity with the upcoming Firefox 3, Safari should have the major OS revision in the user agent.
This can be helpful to the user in many areas, such as if a site had a download for Tiger, and a newer version for Leopard that includes new technologies not available in Tiger, by detecting the user is on Tiger they can opt to suggest the proper download (much like www.getfirefox.com does for OS detection). This makes things easier for mere mortals who don't know about their OS version, just that they want this piece of software.
The Mozilla Bugzilla bug has been linked in the URL field.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Lilek
The OS version was added to the default UA string in <http://trac.webkit.org/projects/webkit/changeset/28499>, which actually includes the bugfix version and not just the major release version.
Tom
Matt: Ahh, I'd gotten confused by this:
http://trac.webkit.org/projects/webkit/changeset/22701
I blame trac search, I should have checked useragent.org first:
Your User Agent is: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13
Is there a bug for a page like about: then, that tells you your UA?
Jesse Ruderman
Indeed, http://delorie.com:81/ says the Safari included with Tiger is:
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_4_11; en) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13
Interesting bit about dots vs underscores in the commit message for http://trac.webkit.org/projects/webkit/changeset/28499.
Tom
(In reply to comment #3)
> Indeed, http://delorie.com:81/ says the Safari included with Tiger is:
>
> User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_4_11; en)
> AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13
I see 3.1, and Tiger came with Safari 2. You upgraded.
Jesse Ruderman
By "Tiger" I mean "the current version of Tiger". It includes Safari 3.1.1 now.
Tom
Ah, so 10.4.11 does include Safari 3.
http://docs.info.apple.com/article.html?artnum=306297
Did not know that.