Bug 182938 – Copying a list from Microsoft Word to TinyMCE fails when mso-list is the first property

• Component: HTML Editing
• Status: RESOLVED FIXED

[Ryosuke Niwa]

See https://bugs.webkit.org/show_bug.cgi?id=182564#c51

When mso-list is the first CSS property, our workaround doesn't kick in.

[Radar WebKit Bug Importer]

<rdar://problem/37683007>

[Andrew Herron]

As we finished capturing the Safari clipboard data for our test documents, another failing case popped up - Word can also put newlines in the style attribute :)

<p class=MsoNormal style='margin-left:0cm;text-indent:0cm;mso-pagination:none;
mso-list:l0 level1 lfo1;mso-layout-grid-align:none;text-autospace:none'>

[Ryosuke Niwa]

Created attachment 336844 [details]
Fixes the bug

[Wenson Hsieh]

Comment on attachment 336844 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=336844&action=review

r=me

> Source/WebCore/editing/markup.cpp:432
> +        return style.startsWith("mso-list:") || style.contains(";mso-list:") || style.contains("\nmso-list:");

I wonder if we should just regex this at some point :P

[Ryosuke Niwa]

(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 336844 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336844&action=review
> 
> r=me
> 
> > Source/WebCore/editing/markup.cpp:432
> > +        return style.startsWith("mso-list:") || style.contains(";mso-list:") || style.contains("\nmso-list:");
> 
> I wonder if we should just regex this at some point :P

Haha, I did think about that.

[Ryosuke Niwa]

Comment on attachment 336844 [details]
Fixes the bug

Thanks for the review. We'd consider using a regular expression if we find more bugs.

[WebKit Commit Bot]

Comment on attachment 336844 [details]
Fixes the bug

Clearing flags on attachment: 336844

Committed r230120: <https://trac.webkit.org/changeset/230120>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andrew Herron]

I have just downloaded r230195 and confirmed that this seems to fix pasting for the relevant documents in our test suite. Thanks :D