Summary: | [GTK][CMake] Support building with Enchant 2.x | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||||||
Component: | WebCore Misc. | Assignee: | Adrian Perez <aperez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, dbates, jamesr, mcatanzaro, mrobinson, senorblanco, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Adrian Perez
2018-02-19 11:07:24 PST
Created attachment 334171 [details]
Patch
Comment on attachment 334171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334171&action=review There's a small typo in the comment, I'll fix it before landing. > Source/cmake/FindEnchant.cmake:48 > + # cases in which e.g. both versions of the library are installed, but on The “on” needs to be deleted in this phrase, it should read “but the headers are usable/present only for one of them”. Created attachment 334172 [details]
Patch
Rebased patch with typo in comment fixed
On a chat with Michael Catanzaro we have agreed that it's probably better to check for Enchant 2.x first, so I'll re-upload the patch with that change done. Comment on attachment 334172 [details]
Patch
This looks good, just swap the order so enchant-2 is checked first, and please add a FIXME to remove the check for old enchant after a couple of years.
Created attachment 334275 [details]
Patch
Created attachment 334277 [details]
Patch for landing
Comment on attachment 334277 [details] Patch for landing Clearing flags on attachment: 334277 Committed r228826: <https://trac.webkit.org/changeset/228826> All reviewed patches have been landed. Closing bug. |