Summary: | Crash under MIMETypeRegistry::isSupportedJavaScriptMIMEType() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Service Workers | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, commit-queue, koivisto, rniwa, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2018-02-19 10:19:21 PST
Created attachment 334185 [details]
Patch
Comment on attachment 334185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334185&action=review > Source/WebCore/platform/MIMETypeRegistry.cpp:502 > + if (!isMainThread()) { > + bool isSupported = false; > + callOnMainThreadAndWait([&isSupported, mimeType = mimeType.isolatedCopy()] { > + isSupported = isSupportedJavaScriptMIMEType(mimeType); > + }); > + return isSupported; > + } It would be nice to make MIMETypeRegistry thread safe in a way that does not involve blocking on main thread. Comment on attachment 334185 [details] Patch Clearing flags on attachment: 334185 Committed r228716: <https://trac.webkit.org/changeset/228716> All reviewed patches have been landed. Closing bug. |