Summary: | Increase text autosizing constants for extra zoom mode | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes, bdakin, commit-queue, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2018-02-18 22:26:24 PST
Created attachment 334137 [details]
Patch
Comment on attachment 334137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334137&action=review > Source/WebCore/page/Settings.yaml:724 > +maxScaleIncrease: Nit - perhaps a more specific name, such as maxTextAutosizingScaleIncrease? At first glance, `maxScaleIncrease` sounds a bit like a viewporty thing. (In reply to Wenson Hsieh from comment #2) > Comment on attachment 334137 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334137&action=review > > > Source/WebCore/page/Settings.yaml:724 > > +maxScaleIncrease: > > Nit - perhaps a more specific name, such as maxTextAutosizingScaleIncrease? > At first glance, `maxScaleIncrease` sounds a bit like a viewporty thing. Yeah, that's a good point. Created attachment 334163 [details]
Patch
Comment on attachment 334163 [details] Patch Clearing flags on attachment: 334163 Committed r228697: <https://trac.webkit.org/changeset/228697> All reviewed patches have been landed. Closing bug. |