Bug 182919

Summary: Increase text autosizing constants for extra zoom mode
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-02-18 22:26:24 PST
Increase text autosizing constants for extra zoom mode
Attachments
Patch (7.55 KB, patch)
2018-02-18 22:26 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (7.67 KB, patch)
2018-02-19 10:10 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-02-18 22:26:47 PST
Created attachment 334137 [details] Patch
Wenson Hsieh
Comment 2 2018-02-19 00:25:38 PST
Comment on attachment 334137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334137&action=review > Source/WebCore/page/Settings.yaml:724 > +maxScaleIncrease: Nit - perhaps a more specific name, such as maxTextAutosizingScaleIncrease? At first glance, `maxScaleIncrease` sounds a bit like a viewporty thing.
Radar WebKit Bug Importer
Comment 3 2018-02-19 08:07:41 PST
<rdar://problem/37671259>
Tim Horton
Comment 4 2018-02-19 10:04:11 PST
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 334137 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334137&action=review > > > Source/WebCore/page/Settings.yaml:724 > > +maxScaleIncrease: > > Nit - perhaps a more specific name, such as maxTextAutosizingScaleIncrease? > At first glance, `maxScaleIncrease` sounds a bit like a viewporty thing. Yeah, that's a good point.
Tim Horton
Comment 5 2018-02-19 10:10:10 PST
Created attachment 334163 [details] Patch
WebKit Commit Bot
Comment 6 2018-02-19 10:47:36 PST
Comment on attachment 334163 [details] Patch Clearing flags on attachment: 334163 Committed r228697: <https://trac.webkit.org/changeset/228697>
WebKit Commit Bot
Comment 7 2018-02-19 10:47:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.