Bug 182875

Summary: Explicitly qualify some method calls on this in lamdas in Service Worker code.
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: Service WorkersAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, japhet, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2018-02-16 07:49:03 PST
.
Attachments
Patch (14.84 KB, patch)
2018-02-16 07:53 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2018-02-16 07:53:40 PST
Created attachment 334042 [details] Patch
Michael Catanzaro
Comment 2 2018-02-19 05:08:01 PST
Comment on attachment 334042 [details] Patch Thanks! Maybe we should just disable service workers support when building with GCC 5, since we're going to drop GCC 5 support in two months anyway. (If it was going to be longer than that, I would r+ this.)
Chris Dumez
Comment 3 2018-02-19 08:23:03 PST
Comment on attachment 334042 [details] Patch This makes me sad but ok I guess.
WebKit Commit Bot
Comment 4 2018-02-19 08:46:29 PST
Comment on attachment 334042 [details] Patch Clearing flags on attachment: 334042 Committed r228691: <https://trac.webkit.org/changeset/228691>
WebKit Commit Bot
Comment 5 2018-02-19 08:46:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-02-19 08:47:20 PST
<rdar://problem/37672651>
Note You need to log in before you can comment on or make changes to this bug.