Bug 182875

Summary:

Explicitly qualify some method calls on this in lamdas in Service Worker code.

Product:

WebKit

Reporter:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Component:

Service Workers

Assignee:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dbates, ews-watchlist, japhet, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ms2ger (he/him; ⌚ UTC+1/+2) 2018-02-16 07:49:03 PST

Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-02-16 07:53:40 PST

Created attachment 334042 [details]
Patch

Comment 2 Michael Catanzaro 2018-02-19 05:08:01 PST

Comment on attachment 334042 [details]
Patch

Thanks! Maybe we should just disable service workers support when building with GCC 5, since we're going to drop GCC 5 support in two months anyway. (If it was going to be longer than that, I would r+ this.)

Comment 3 Chris Dumez 2018-02-19 08:23:03 PST

Comment on attachment 334042 [details]
Patch

This makes me sad but ok I guess.

Comment 4 WebKit Commit Bot 2018-02-19 08:46:29 PST

Comment on attachment 334042 [details]
Patch

Clearing flags on attachment: 334042

Committed r228691: <https://trac.webkit.org/changeset/228691>

Comment 5 WebKit Commit Bot 2018-02-19 08:46:31 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-02-19 08:47:20 PST

<rdar://problem/37672651>