Bug 182854

Summary:

Disable release assertions in updateStyleIfNeeded and updateLayout

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Ryosuke Niwa <rniwa>

Status:

NEW ---

Severity:

Normal

CC:

bfulgham, cdumez, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Disable release asserts	simon.fraser: review+
Fixed release builds	none

Description Ryosuke Niwa 2018-02-15 17:35:23 PST

We need to disable release assertions in updateStyleIfNeeded and updateLayout.

Comment 1 Ryosuke Niwa 2018-02-15 17:39:08 PST

<rdar://problem/37590759>

Comment 2 Ryosuke Niwa 2018-02-15 17:42:39 PST

Created attachment 333976 [details]
Disable release asserts

Comment 3 EWS Watchlist 2018-02-15 17:45:06 PST

Attachment 333976 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:1969:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/Document.cpp:1985:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/page/LayoutContext.cpp:125:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Ryosuke Niwa 2018-02-15 17:52:00 PST

Created attachment 333977 [details]
Fixed release builds

Comment 5 EWS Watchlist 2018-02-15 17:54:24 PST

Attachment 333977 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:1971:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/Document.cpp:1987:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/page/LayoutContext.cpp:125:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.