Web Inspector: TabBar redesign: TabBarItem close button is incorrectly positioned

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

Created attachment 333958 [details]
[Image] Close button location bug

Summary:
TabBarItem close button is incorrectly positioned. The initial round of TabBar changes (https://webkit.org/b/181468) went too far, removing or changing stuff that should have stayed put.

Steps to Reproduce:
1. Open Inspector
2. Disable the New Tab Bar experimental setting
3. Open Search (or New Tab) tab
4. Make sure TabBar is not collapsed (width enough to show tab icons and text)
5. Hover the Search (or New Tab) tab

Expected:
Left-aligned close button (x) is shown.

Actual:
Tab icon is replaced by the close button (see attached screenshot).

[Radar WebKit Bug Importer]

<rdar://problem/37586749>

[Matt Baker]

Created attachment 333959 [details]
Patch

[Matt Baker]

Created attachment 333960 [details]
[Image] with patch applied

[Matt Baker]

(In reply to Matt Baker from comment #3)
> Created attachment 333960 [details]
> [Image] with patch applied

(In reply to Matt Baker from comment #0)
> Created attachment 333958 [details]
> [Image] Close button location bug
> 
> Summary:
> TabBarItem close button is incorrectly positioned. The initial round of
> TabBar changes (https://webkit.org/b/181468) went too far, removing or
> changing stuff that should have stayed put.
> 
> Steps to Reproduce:
> 1. Open Inspector
> 2. Disable the New Tab Bar experimental setting

Disregard step 2. Close button behavior should not be impacted by this setting.

[Matt Baker]

Created attachment 333985 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 333985 [details]
Patch

Rejecting attachment 333985 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333985, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://webkit-queues.webkit.org/results/6540684

[WebKit Commit Bot]

Comment on attachment 333985 [details]
Patch

Clearing flags on attachment: 333985

Committed r228573: <https://trac.webkit.org/changeset/228573>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.