Bug 182820

Summary:

Simplify TimerHandler bindings and timer implementation

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

cdumez, esprehn+autocc, ews-watchlist, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, saam, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews205 for win-future	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews206 for win-future	none

Darin Adler

Reported 2018-02-14 21:01:32 PST

Simpify TimerHandler bindings and timer implementation

Attachments
Patch (57.99 KB, patch) 2018-02-14 21:20 PST, Darin Adler	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.26 MB, application/zip) 2018-02-14 22:38 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.65 MB, application/zip) 2018-02-14 22:45 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (11.58 MB, application/zip) 2018-02-14 23:08 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (11.51 MB, application/zip) 2018-02-14 23:51 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (2.92 MB, application/zip) 2018-02-15 01:12 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews206 for win-future (11.49 MB, application/zip) 2018-02-15 01:48 PST, EWS Watchlist	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2018-02-14 21:20:12 PST

Created attachment 333873 [details] Patch

EWS Watchlist

Comment 2 2018-02-14 22:38:24 PST

Comment on attachment 333873 [details] Patch Attachment 333873 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6512410 New failing tests: imported/w3c/web-platform-tests/html/webappapis/timers/evil-spec-example.html fast/dom/Window/setTimeout-string-argument.html

EWS Watchlist

Comment 3 2018-02-14 22:38:26 PST Comment hidden (obsolete)

Created attachment 333876 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-02-14 22:45:34 PST Comment hidden (obsolete)

Comment on attachment 333873 [details] Patch Attachment 333873 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6512483 New failing tests: imported/w3c/web-platform-tests/html/webappapis/timers/evil-spec-example.html fast/dom/Window/setTimeout-string-argument.html

EWS Watchlist

Comment 5 2018-02-14 22:45:35 PST Comment hidden (obsolete)

Created attachment 333877 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-02-14 23:08:54 PST Comment hidden (obsolete)

Comment on attachment 333873 [details] Patch Attachment 333873 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6512522 New failing tests: imported/w3c/web-platform-tests/html/webappapis/timers/evil-spec-example.html fast/dom/Window/setTimeout-string-argument.html

EWS Watchlist

Comment 7 2018-02-14 23:08:55 PST Comment hidden (obsolete)

Created attachment 333879 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-02-14 23:51:35 PST Comment hidden (obsolete)

Comment on attachment 333873 [details] Patch Attachment 333873 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6512682 New failing tests: fast/dom/Window/setTimeout-string-argument.html

EWS Watchlist

Comment 9 2018-02-14 23:51:46 PST Comment hidden (obsolete)

Created attachment 333881 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 10 2018-02-15 01:12:11 PST Comment hidden (obsolete)

Comment on attachment 333873 [details] Patch Attachment 333873 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6513628 New failing tests: imported/w3c/web-platform-tests/html/webappapis/timers/evil-spec-example.html fast/dom/Window/setTimeout-string-argument.html

EWS Watchlist

Comment 11 2018-02-15 01:12:12 PST Comment hidden (obsolete)

Created attachment 333885 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 12 2018-02-15 01:48:03 PST Comment hidden (obsolete)

Comment on attachment 333873 [details] Patch Attachment 333873 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6513953 New failing tests: fast/dom/Window/setTimeout-string-argument.html

EWS Watchlist

Comment 13 2018-02-15 01:48:14 PST Comment hidden (obsolete)

Created attachment 333886 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Darin Adler

Comment 14 2018-12-15 15:05:29 PST

I’m not going to bother with this.

Note You need to log in before you can comment on or make changes to this bug.