Summary: | Support scrolling for non-editable web-selection and start autoscroll when near screen edges | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bdakin, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Megan Gardner
2018-02-14 15:56:51 PST
Created attachment 333855 [details]
Patch
Comment on attachment 333855 [details] Patch Attachment 333855 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6509104 New failing tests: editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html fast/forms/textfield-no-linebreak.html editing/execCommand/enabling-and-selection-2.html editing/pasteboard/copy-standalone-image.html fast/css-grid-layout/grid-simplified-layout-positioned.html fast/forms/textarea/textarea-placeholder-paint-order-2.html fast/forms/input-placeholder-paint-order-2.html fast/css/caret-color-auto.html Created attachment 333863 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 333864 [details]
Patch
Comment on attachment 333864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333864&action=review > Source/WebCore/page/ios/EventHandlerIOS.mm:589 > + FloatPoint edgeDistanceThreashold; “Threashold" > Source/WebCore/page/ios/EventHandlerIOS.mm:591 > + edgeDistanceThreashold.setX(screenRect.width() / 10); > + edgeDistanceThreashold.setY(screenRect.height() / 10); I think this could be FloatPoint edgeDistanceThreshold = toFloatPoint(screenRect.size()); edgeDistanceThreshold.scale(1. / 10); if you wanted to repeat yourself less. I’m sure there are similar ways to use FloatPoint/Size/etc. to make the rest of the code less wordy, but w/e. > Source/WebCore/page/ios/EventHandlerIOS.mm:629 > + FloatRect unobscuredContetRect = protectedFrame->view()->unobscuredContentRect(); Contet Created attachment 333946 [details]
Patch
Created attachment 333954 [details]
Patch
Comment on attachment 333954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333954&action=review > Source/WebCore/page/ios/EventHandlerIOS.mm:591 > + FloatPoint edgeDistanceThreashold = toFloatPoint(screenRect.size()); Still threashold???? > Source/WebCore/page/ios/EventHandlerIOS.mm:592 > + edgeDistanceThreashold.scale(1. / 10); Maybe reconsider the 10% part? It seems weird that the threshold will be wildly different between iPad Pro and a small iPhone. > Source/WebCore/page/ios/EventHandlerIOS.mm:633 > + // This will need to be revisited if delegatedScrolling is updated Updated? I don’t think we need this comment. > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1828 > + else if (!m_assistedNode) { Probably can just be an else. |