Bug 182799

Summary:

WebCore headers should not include config.h or PlatformExportMacros.h

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

WebCore Misc.

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, darin, mcatanzaro, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Don Olmstead

Reported 2018-02-14 11:22:11 PST

Currently in WebCore a number of headers include PlatformExportMacros.h. This should only be included within config.h One file actually includes config.h directly which is a private header. These cases should be removed.

Attachments
Patch (10.75 KB, patch) 2018-02-14 11:25 PST, Don Olmstead	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2018-02-14 11:25:37 PST

Created attachment 333821 [details] Patch

WebKit Commit Bot

Comment 2 2018-02-14 13:23:08 PST

Comment on attachment 333821 [details] Patch Clearing flags on attachment: 333821 Committed r228483: <https://trac.webkit.org/changeset/228483>

WebKit Commit Bot

Comment 3 2018-02-14 13:23:09 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 4 2018-02-14 13:24:32 PST

<rdar://problem/37545921>

Note You need to log in before you can comment on or make changes to this bug.