Bug 182784

Summary: Fix ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: HTML EditingAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, mcatanzaro, rniwa, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184884
https://bugs.webkit.org/show_bug.cgi?id=186555
Attachments:
Description Flags
WIP patch
none
Patch rniwa: review-, rniwa: commit-queue-

Fujii Hironori
Reported 2018-02-14 03:09:36 PST
Fix ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren
Attachments
WIP patch (1.13 KB, patch)
2018-02-14 03:10 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (2.36 KB, patch)
2018-02-15 22:33 PST, Fujii Hironori 		rniwa: review-
rniwa: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-02-14 03:10:05 PST
Created attachment 333780 [details] WIP patch
Fujii Hironori
Comment 2 2018-02-15 22:33:30 PST
Created attachment 334004 [details] Patch
Michael Catanzaro
Comment 3 2018-02-16 09:28:20 PST
Comment on attachment 334004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334004&action=review > Source/WebCore/ChangeLog:13 > + No new tests (No behavior change) This is definitely a behavior change... maybe you could explain at a higher-level what you've fixed, why this is correct, and why it's hard to write a test for it.
Ryosuke Niwa
Comment 4 2018-02-16 21:43:28 PST
Comment on attachment 334004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334004&action=review >> Source/WebCore/ChangeLog:13 >> + No new tests (No behavior change) > > This is definitely a behavior change... maybe you could explain at a higher-level what you've fixed, why this is correct, and why it's hard to write a test for it. Yes, we definitely need a test.
Fujii Hironori
Comment 5 2018-06-13 23:19:08 PDT
Fixed in bug 186555.
Note You need to log in before you can comment on or make changes to this bug.