Summary: | REGRESSION(r228279): [GTK] Many aria tests are now flaky | ||
---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
Component: | Accessibility | Assignee: | Carlos Garcia Campos <cgarcia> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | cfleizach, clopez, dpino, jdiggs, mcatanzaro, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=182386 |
Description
Michael Catanzaro
2018-02-13 19:17:08 PST
webkit.org/b/182761 accessibility/gtk/aria-busy-changed-notification.html [ Pass Failure ] webkit.org/b/182761 accessibility/gtk/aria-current-changed-notification.html [ Pass Failure ] webkit.org/b/182761 accessibility/gtk/aria-disabled-changed-notification.html [ Pass Failure ] webkit.org/b/182761 accessibility/gtk/aria-expanded-changed-notification.html [ Pass Failure ] webkit.org/b/182761 accessibility/gtk/aria-pressed-changed-notification.html [ Pass Failure ] webkit.org/b/182761 accessibility/gtk/aria-readonly-changed-notification.html [ Pass Failure ] webkit.org/b/182761 accessibility/gtk/aria-required-changed-notification.html [ Pass Failure ] These tests will need to be updated to account for attribute chnages being deferred. Usually that means putting the check inside a set timeout after setting the attribute. Joanie’s expertise will Probably be needed to evaluate but it shouldn’t be too hard When are we going to get gtk tests in EWS? (In reply to chris fleizach from comment #4) > When are we going to get gtk tests in EWS? Hopefully soon! We first need to be sure it doesn't turn red for preexisting failures as often as the Mac EWS currently does, since spurious failures on the Mac EWS are already annoying, and GTK layout tests are never in as good a state as the Mac tests. I think the current plan is to change the EWS to run failing tests several times with and without the patch to figure out if the test was already flaky or not. GTK post-commit bot reports these tests have been consistently failing for the last 4000 revisions. They need at least to get their baselines updated. Done in r278632. I won't remove the tests for now. But in the future it would be worth to revisit these tests and check if their tests are consistently passing for a large number of revisions. In that case it would be safe to remove the tests from test expectations and close this bug. Pull request: https://github.com/WebKit/WebKit/pull/13572 Committed 263855@main (4f4e045dca43): <https://commits.webkit.org/263855@main> Reviewed commits have been landed. Closing PR #13572 and removing active labels. |