Bug 182744

Summary: REGRESSION(r228313): Membuster | macOS | All Devices | 1.5 MB
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Description Antti Koivisto 2018-02-13 13:39:45 PST 
Need to respect low memory notifications explicitly now that the compiled selectors are not part of RuleDatas.
Comment 1 Antti Koivisto 2018-02-13 15:28:17 PST 
<rdar://problem/37463770>
Comment 2 Antti Koivisto 2018-02-13 15:31:19 PST 
Created attachment 333736 [details]
patch
Comment 3 EWS Watchlist 2018-02-13 15:32:28 PST 
Attachment 333736 [details] did not pass style-queue:


ERROR: Source/WebCore/css/StyleSheetContents.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:433:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:466:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:478:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2018-02-13 18:36:41 PST 
Created attachment 333758 [details]
patch
Comment 5 EWS Watchlist 2018-02-13 18:38:09 PST 
Attachment 333758 [details] did not pass style-queue:


ERROR: Source/WebCore/css/StyleSheetContents.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:433:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:466:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:478:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2018-02-13 20:38:38 PST 
Comment on attachment 333758 [details]
patch

Clearing flags on attachment: 333758

Committed r228453: <https://trac.webkit.org/changeset/228453>
Comment 7 WebKit Commit Bot 2018-02-13 20:38:39 PST 
All reviewed patches have been landed.  Closing bug.