Bug 182729 – run-jsc-stress-tests - skip a test if any of the run commands evals to skip

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Tomas Popela]

Imagine, that we have the following run command in the beginning of some stress tests:

//@ defaultNoEagerRun

now, we don't want to run this test if JIT is disabled (because the test is failing there). What we could do is:

//@ if $jitTests then defaultNoEagerRun else skip end

but I personally don't like it.. Better would be to use:

//@ skip if not $jitTests
//@ defaultNoEagerRun

but this does not work right now, because Tools/Scripts/run-jsc-stress-tests will analyse the first line, skip the run as expected, but then will start to analyse the second line and will schedule a run. We should skip further analysis if the test is skipped.

[Tomas Popela]

Created attachment 333688 [details]
Patch

[Saam Barati]

Comment on attachment 333688 [details]
Patch

r=me

The only thing slightly unintuitive here is you could have code like:
//@ runXYZ
//@ skip

And we’ll print out that we’re skipping. But it’s probably ok to not care about this

[Tomas Popela]

Comment on attachment 333688 [details]
Patch

Clearing flags on attachment: 333688

Committed r228512: <https://trac.webkit.org/changeset/228512>

[Tomas Popela]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37571539>