Bug 182700

Summary: [RenderTreeBuilder] Remove redundant RenderTreeBuilder instance
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2018-02-12 10:39:04 PST
Now that we pass the builder in.
Attachments
Patch (1.30 KB, patch)
2018-02-12 10:40 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (1.34 KB, patch)
2018-02-12 10:52 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (2.17 KB, patch)
2018-02-12 11:56 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-12 10:39:34 PST
<rdar://problem/37463958>
alan
Comment 2 2018-02-12 10:40:33 PST
Created attachment 333606 [details] Patch
WebKit Commit Bot
Comment 3 2018-02-12 10:44:28 PST
Comment on attachment 333606 [details] Patch Rejecting attachment 333606 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 333606, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/6468089
alan
Comment 4 2018-02-12 10:52:44 PST
Created attachment 333608 [details] Patch
alan
Comment 5 2018-02-12 11:56:26 PST
Created attachment 333611 [details] Patch
WebKit Commit Bot
Comment 6 2018-02-12 12:12:40 PST
Comment on attachment 333611 [details] Patch Clearing flags on attachment: 333611 Committed r228387: <https://trac.webkit.org/changeset/228387>
WebKit Commit Bot
Comment 7 2018-02-12 12:12:42 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 8 2018-02-12 12:40:38 PST
Comment on attachment 333611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333611&action=review > Source/WebCore/dom/Document.cpp:2319 > + RenderTreeBuilder builder(*m_renderView); Not clear why you need one here; you didn't say any words. > Source/WebCore/rendering/RenderView.cpp:619 > + while (firstChild()) > + removeAndDestroyChild(builder, *firstChild()); Why don't you need one here?
Note You need to log in before you can comment on or make changes to this bug.