Bug 182700

Summary: [RenderTreeBuilder] Remove redundant RenderTreeBuilder instance
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2018-02-12 10:39:04 PST
Now that we pass the builder in.
Comment 1 Radar WebKit Bug Importer 2018-02-12 10:39:34 PST
<rdar://problem/37463958>
Comment 2 zalan 2018-02-12 10:40:33 PST
Created attachment 333606 [details]
Patch
Comment 3 WebKit Commit Bot 2018-02-12 10:44:28 PST
Comment on attachment 333606 [details]
Patch

Rejecting attachment 333606 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 333606, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/6468089
Comment 4 zalan 2018-02-12 10:52:44 PST
Created attachment 333608 [details]
Patch
Comment 5 zalan 2018-02-12 11:56:26 PST
Created attachment 333611 [details]
Patch
Comment 6 WebKit Commit Bot 2018-02-12 12:12:40 PST
Comment on attachment 333611 [details]
Patch

Clearing flags on attachment: 333611

Committed r228387: <https://trac.webkit.org/changeset/228387>
Comment 7 WebKit Commit Bot 2018-02-12 12:12:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Simon Fraser (smfr) 2018-02-12 12:40:38 PST
Comment on attachment 333611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333611&action=review

> Source/WebCore/dom/Document.cpp:2319
> +        RenderTreeBuilder builder(*m_renderView);

Not clear why you need one here; you didn't say any words.

> Source/WebCore/rendering/RenderView.cpp:619
> +    while (firstChild())
> +        removeAndDestroyChild(builder, *firstChild());

Why don't you need one here?