Summary: | Add C SPI for support of Website Data Store in Website Policies | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Maureen Daum <mdaum> | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, aestes, commit-queue, ews-watchlist, mdaum, sam, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Maureen Daum
2018-02-12 09:48:48 PST
Created attachment 333602 [details]
patch
Attachment 333602 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/API/C/WKWebsitePolicies.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 333604 [details]
patch (with alphabetical sorting issue addressed)
From the patch, it looks like you mean "the C-SPI". Legacy WebKit is what we refer to the original "WebKit 1" framework and API as. You're correct that I should be referring to "the C-SPI". Thanks for explaining what "Legacy WebKit" refers to! Created attachment 333623 [details]
patch (referring to "C API" instead of "Legacy WebKit")
Comment on attachment 333623 [details] patch (referring to "C API" instead of "Legacy WebKit") View in context: https://bugs.webkit.org/attachment.cgi?id=333623&action=review > Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:54 > + RELEASE_ASSERT_WITH_MESSAGE(sessionID.isEphemeral() || sessionID == PAL::SessionID::defaultSessionID(), "WebsiteDataStore must be nil, default, or non-persistent."); The wording here isn't quite right, since "default" and "non-persistent" apply to the data store's session, not the data store itself. Also, "nil" isn't the right term in C. > Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:55 > + RELEASE_ASSERT_WITH_MESSAGE(toImpl(policyListenerRef)->isMainFrame(), "WebsiteDataStore must be nil for subframe navigations."); Same comment about "nil". > Source/WebKit/UIProcess/WebFrameListenerProxy.h:50 > + bool isMainFrame(); This should be const-qualified. Comment on attachment 333623 [details] patch (referring to "C API" instead of "Legacy WebKit") View in context: https://bugs.webkit.org/attachment.cgi?id=333623&action=review >> Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:54 >> + RELEASE_ASSERT_WITH_MESSAGE(sessionID.isEphemeral() || sessionID == PAL::SessionID::defaultSessionID(), "WebsiteDataStore must be nil, default, or non-persistent."); > > The wording here isn't quite right, since "default" and "non-persistent" apply to the data store's session, not the data store itself. Also, "nil" isn't the right term in C. Changed to "If WebsitePolicies specifies a WebsiteDataStore, the data store's session must be default or non-persistent." >> Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:55 >> + RELEASE_ASSERT_WITH_MESSAGE(toImpl(policyListenerRef)->isMainFrame(), "WebsiteDataStore must be nil for subframe navigations."); > > Same comment about "nil". Changed to "WebsitePolicies cannot specify a WebsiteDataStore for subframe navigations." >> Source/WebKit/UIProcess/WebFrameListenerProxy.h:50 >> + bool isMainFrame(); > > This should be const-qualified. Done. Created attachment 333754 [details]
patch
Comment on attachment 333754 [details] patch Clearing flags on attachment: 333754 Committed r228472: <https://trac.webkit.org/changeset/228472> All reviewed patches have been landed. Closing bug. |