Bug 182691

Summary: [ARM] Debug build does not compile
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dominik.infuehr, ews-watchlist, guijemont, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v2 none

Description Dominik Inführ 2018-02-12 03:31:54 PST 
Created attachment 333587 [details]
Patch

Debug builds of JSC do not compile on ARMv7 due to compile error in assert statement. Fix it by invoking unpoisoned() on the argument, such that reinterpret_cast<intptr>() works again.
Comment 1 Dominik Inführ 2018-02-21 05:54:44 PST 
Created attachment 334366 [details]
Patch v2
Comment 2 Dominik Inführ 2018-02-21 06:03:49 PST 
Created attachment 334371 [details]
Patch v2
Comment 3 Mark Lam 2018-02-28 10:15:46 PST 
Comment on attachment 334371 [details]
Patch v2

r=me
Comment 4 WebKit Commit Bot 2018-02-28 23:35:34 PST 
Comment on attachment 334371 [details]
Patch v2

Clearing flags on attachment: 334371

Committed r229125: <https://trac.webkit.org/changeset/229125>
Comment 5 WebKit Commit Bot 2018-02-28 23:35:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-28 23:36:35 PST 
<rdar://problem/38017124>