Bug 182691

Summary: [ARM] Debug build does not compile
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dominik.infuehr, ews-watchlist, guijemont, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v2 none

Dominik Inführ
Reported 2018-02-12 03:31:54 PST
Created attachment 333587 [details] Patch Debug builds of JSC do not compile on ARMv7 due to compile error in assert statement. Fix it by invoking unpoisoned() on the argument, such that reinterpret_cast<intptr>() works again.
Attachments
Patch (2.67 KB, patch)
2018-02-12 03:31 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.67 KB, patch)
2018-02-21 05:54 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.67 KB, patch)
2018-02-21 06:03 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-02-21 05:54:44 PST
Created attachment 334366 [details] Patch v2
Dominik Inführ
Comment 2 2018-02-21 06:03:49 PST
Created attachment 334371 [details] Patch v2
Mark Lam
Comment 3 2018-02-28 10:15:46 PST
Comment on attachment 334371 [details] Patch v2 r=me
WebKit Commit Bot
Comment 4 2018-02-28 23:35:34 PST
Comment on attachment 334371 [details] Patch v2 Clearing flags on attachment: 334371 Committed r229125: <https://trac.webkit.org/changeset/229125>
WebKit Commit Bot
Comment 5 2018-02-28 23:35:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-02-28 23:36:35 PST
<rdar://problem/38017124>
Note You need to log in before you can comment on or make changes to this bug.