Bug 182685

Summary: CanvasRenderingContext2DBase: use CanvasBase more extensively
Product: WebKit Reporter: Zan Dobersek <zan>
Component: CanvasAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aperez, cdumez, clopez, clord, commit-queue, dino, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, sabouhallawa, simon.fraser, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 182503    
Bug Blocks: 183720, 182686    
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Zan Dobersek
Reported 2018-02-11 23:27:11 PST
In CanvasRenderingContext2DBase, instead of downcasting the CanvasBase object to HTMLCanvasElement, call CanvasBase methods introduced in bug #182503, making it possible for OffscreenCanvas to leverage this class properly.
Attachments
WIP patch (11.57 KB, patch)
2018-02-11 23:28 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (14.84 KB, patch)
2018-03-01 01:48 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (9.14 KB, patch)
2019-10-01 04:17 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (9.14 KB, patch)
2019-10-10 02:58 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (9.14 KB, patch)
2019-10-17 02:34 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (9.19 KB, patch)
2019-11-01 02:35 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-02-11 23:28:47 PST
Created attachment 333582 [details] WIP patch Depends on changes in bug #182503.
Zan Dobersek
Comment 2 2018-03-01 01:48:02 PST
Created attachment 334802 [details] Patch Reviewable, but still depends on bug #182503.
Chris Lord
Comment 3 2019-10-01 04:17:36 PDT
Created attachment 379890 [details] Patch
Chris Lord
Comment 4 2019-10-10 02:58:14 PDT
Created attachment 380621 [details] Patch
Chris Lord
Comment 5 2019-10-17 02:34:05 PDT
Created attachment 381184 [details] Patch
Chris Lord
Comment 6 2019-11-01 02:35:02 PDT
Created attachment 382568 [details] Patch
Adrian Perez
Comment 7 2019-11-01 04:08:17 PDT
Comment on attachment 382568 [details] Patch Patch LGTM. Let's wait until all the EWS bots pass before setting cq+ :-)
WebKit Commit Bot
Comment 8 2019-11-01 05:55:35 PDT
Comment on attachment 382568 [details] Patch Clearing flags on attachment: 382568 Committed r251914: <https://trac.webkit.org/changeset/251914>
WebKit Commit Bot
Comment 9 2019-11-01 05:55:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-11-01 05:56:16 PDT
<rdar://problem/56814353>
Note You need to log in before you can comment on or make changes to this bug.