Bug 182684 – [css-grid] Apply automatic minimum size clamping to spanning items too

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Manuel Rego Casasnovas]

[css-grid] Apply automatic minimum size clamping to spanning items too

[Manuel Rego Casasnovas]

Created attachment 333580 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 333585 [details]
Patch

[Javier Fernandez]

Comment on attachment 333585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333585&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:751
> +        const GridSpan& span = m_algorithm.grid().gridItemSpan(child, direction());

We can use 'auto' here too.
Actually, it seems we only use the variable in the loop definition; we could just call gridItemSpan there and avoid this variable.

[Manuel Rego Casasnovas]

Created attachment 334148 [details]
Patch for landing

[Manuel Rego Casasnovas]

Comment on attachment 333585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333585&action=review

Thanks for the review

>> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:751
>> +        const GridSpan& span = m_algorithm.grid().gridItemSpan(child, direction());
> 
> We can use 'auto' here too.
> Actually, it seems we only use the variable in the loop definition; we could just call gridItemSpan there and avoid this variable.

True, I've moved the call to the for loop. Nice catch.

[WebKit Commit Bot]

Comment on attachment 334148 [details]
Patch for landing

Clearing flags on attachment: 334148

Committed r228661: <https://trac.webkit.org/changeset/228661>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37666607>