Summary: | [RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
zalan
2018-02-09 15:57:41 PST
Created attachment 333531 [details]
Patch
Comment on attachment 333531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333531&action=review > Source/WebCore/rendering/RenderBlock.cpp:499 > + return builder.takenChildFromRenderBlock(*this, oldChild); takeChild > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:473 > +RenderPtr<RenderObject> RenderTreeBuilder::takenChildFromRenderBlock(RenderBlock& parent, RenderObject& oldChild) taken Created attachment 333549 [details]
Patch
Created attachment 333551 [details]
Patch
Comment on attachment 333551 [details] Patch Rejecting attachment 333551 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 333551, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/6446004 Created attachment 333556 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 333556 [details]: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-to-dataurl.html bug 182270 (author: youennf@gmail.com) imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.https.html bug 182396 (author: youennf@gmail.com) http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html bug 179840 (authors: ap@webkit.org and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 333556 [details] Patch Clearing flags on attachment: 333556 Committed r228365: <https://trac.webkit.org/changeset/228365> All reviewed patches have been landed. Closing bug. |