Bug 182645

Summary: [CMake] Make PAL headers copies
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 180064    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Don Olmstead 2018-02-09 11:40:31 PST
PAL headers should be copies.
Comment 1 Don Olmstead 2018-02-09 11:54:53 PST
Created attachment 333506 [details]
Patch
Comment 2 Don Olmstead 2018-02-09 11:58:52 PST
Created attachment 333507 [details]
Patch
Comment 3 Don Olmstead 2018-02-09 12:11:31 PST
Created attachment 333509 [details]
Patch
Comment 4 EWS Watchlist 2018-02-09 12:12:48 PST
Attachment 333509 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/PlatformMac.cmake:83:  There should be exactly one empty line instead of 0 between "spi/mac/TUCallSPI.h" and "spi/win/CoreTextSPIWin.h".  [list/emptyline] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Don Olmstead 2018-02-09 12:34:51 PST
Created attachment 333510 [details]
Patch
Comment 6 Don Olmstead 2018-02-09 12:36:23 PST
Created attachment 333511 [details]
Patch
Comment 7 Don Olmstead 2018-02-09 12:45:24 PST
Created attachment 333512 [details]
Patch
Comment 8 WebKit Commit Bot 2018-02-09 16:51:16 PST
Comment on attachment 333512 [details]
Patch

Clearing flags on attachment: 333512

Committed r228347: <https://trac.webkit.org/changeset/228347>
Comment 9 WebKit Commit Bot 2018-02-09 16:51:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-02-09 16:52:25 PST
<rdar://problem/37410560>