Bug 182603
| Summary: | REGRESSION(r228260): [GTK] Broke several web workers tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, cdumez, darin, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=179591 | ||
Miguel Gomez
r228260 caused several tests to start failing, crashing or timing out:
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Failure ]
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm [ Failure ]
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno.htm [ Failure ]
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message.htm [ Failure ]
imported/w3c/web-platform-tests/workers/Worker_ErrorEvent_error.htm [ Failure ]
imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html [ Failure ]
imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/handled.html [ Failure ]
storage/indexeddb/transaction-complete-workers-private.html [ Crash ]
storage/indexeddb/transaction-complete-workers.html [ Crash ]
fast/workers/worker-script-error.html [ Timeout ]
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Can you post text diffs for the tests with failure results, and backtraces for the tests that crash? Otherwise, it's not likely that anybody will look at this bug.
Also, it's helpful to include the name of the commit alongside the revision number. These regressions were caused by r228260 "Event improvements". The commit name should help Darin understand why he was CCed. :)
Miguel Gomez
(In reply to Michael Catanzaro from comment #1)
> Can you post text diffs for the tests with failure results, and backtraces
> for the tests that crash? Otherwise, it's not likely that anybody will look
> at this bug.
Incoming diffs!!
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno-actual.txt
@@ -1,4 +1,6 @@
CONSOLE MESSAGE: line 3: Error: Error Message
-PASS WorkerGlobalScope onerror event handler argument: col
+Harness Error (TIMEOUT), message = null
+TIMEOUT WorkerGlobalScope onerror event handler argument: col Test timed out
+
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename-actual.txt
@@ -1,4 +1,6 @@
CONSOLE MESSAGE: line 3: Error: Error Message
-PASS WorkerGlobalScope onerror event handler argument: location
+Harness Error (TIMEOUT), message = null
+TIMEOUT WorkerGlobalScope onerror event handler argument: location Test timed out
+
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno.htm [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno-actual.txt
@@ -1,4 +1,6 @@
CONSOLE MESSAGE: line 3: Error: Error Message
-PASS WorkerGlobalScope onerror event handler argument: line
+Harness Error (TIMEOUT), message = null
+TIMEOUT WorkerGlobalScope onerror event handler argument: line Test timed out
+
imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message.htm [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message-actual.txt
@@ -1,4 +1,6 @@
CONSOLE MESSAGE: line 3: Error: Error Message
-PASS WorkerGlobalScope onerror event handler argument: message
+Harness Error (TIMEOUT), message = null
+TIMEOUT WorkerGlobalScope onerror event handler argument: message Test timed out
+
imported/w3c/web-platform-tests/workers/Worker_ErrorEvent_error.htm [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/Worker_ErrorEvent_error-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/Worker_ErrorEvent_error-actual.txt
@@ -1,6 +1,8 @@
CONSOLE MESSAGE: line 9: hello
+Harness Error (TIMEOUT), message = null
+
PASS Error handler outside the worker should not see the error value
-PASS Error handlers inside a worker should see the error value
+TIMEOUT Error handlers inside a worker should see the error value Test timed out
PASS Untitled
imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror-actual.txt
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: line 3: ReferenceError: Can't find variable: y
PASS onerror, "not handled" with an error in the onerror function
imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/handled.html [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/handled-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/handled-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 7: ReferenceError: Can't find variable: y
-PASS onerror, "handled"
+FAIL onerror, "handled" assert_unreached: Reached unreachable code
Chris Dumez
I believe I fixed this in trac.webkit.org/r228276. Do you still experience these issues in the GTK port? The issues when away on Mac / iOS ports.
Chris Dumez
Tentatively marking as resolved by trac.webkit.org/changeset/228276/webkit as I do not see these tests failing on the GTK bots (anymore). Please reopen if there is still an issue for the GTK port caused by r228260 and I will help.
Michael Catanzaro
Thanks Chris! I bet you solved it, indeed. I'll remove the expectations.